Skip to content

Partial fixes and clarifications for issues raised in #30 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Zador-Pataki wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Partial fixes and clarifications for issues raised in #30 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ python scripts/benchmark.py \
-d eth3d \ # (default) benchmark dataset
-m minimal \ # overlap level [/leq5/leq10/leq30/all]
-s facade \ # scene [/courtyard/electro/...]
--testset_id 0 \ # id of an ovelrap level (in this case minimal)
--testset_id 0 # id of an ovelrap level (in this case minimal)
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the comment: 'ovelrap' should be 'overlap'.

Suggested change
--testset_id 0 # id of an ovelrap level (in this case minimal)
--testset_id 0 # id of an overlap level (in this case minimal)

Copilot uses AI. Check for mistakes.
```


Expand Down
2 changes: 2 additions & 0 deletions mpsfm/test/simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def __call__(
images_dir=None,
):
data_dir = Path(data_dir)
cache_dir = Path(cache_dir) if cache_dir is not None else None
images_dir = Path(images_dir) if images_dir is not None else None

scene_parser = SimpleParser(
data_dir=data_dir,
Expand Down