Skip to content

docs: improve narrative flow and clarify demonstrative referents - #1167

Closed
dem-extra1 wants to merge 1 commit into
mainfrom
jules-4023447441863774725-17ee6e19
Closed

dem-extra1 wants to merge 1 commit into
mainfrom
jules-4023447441863774725-17ee6e19

Conversation

@dem-extra1

Copy link
Copy Markdown
Collaborator

Improve narrative flow and clarify demonstrative referents across textbook chapters and subfiles:

  • Replace bare/ambiguous demonstratives with explicit noun phrases in _sec_hers_lm_diagnostics_lm2.qmd and _sec_linreg_wald.qmd.
  • Replace spatial reference ('below') with 'following' in parametric-survival-models.qmd.

PR created automatically by Jules for task 4023447441863774725 started by @dem-extra1

Co-authored-by: dem-extra1 <112029334+dem-extra1@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


Review: #1167 — "docs: improve narrative flow and clarify demonstrative referents"

Scope: Three one-word/one-phrase prose edits, each replacing a bare demonstrative or spatial reference with an explicit noun phrase, per this repo's CLAUDE.md rules:

  • "Always add a noun phrase after 'This', 'That', and 'Those' to clarify the referent"
  • "Never use 'above' or 'below' to refer to content"

Findings

_subfiles/Linear-models-overview/_sec_hers_lm_diagnostics_lm2.qmd:53This previewsThis residual pattern previews. Correct referent: the preceding sentence discusses the residual/QQ plots looking identical between models. Accurate and satisfies the noun-phrase rule.

_subfiles/Linear-models-overview/_sec_linreg_wald.qmd:78This matchesThis calculated p-value matches. Correct: immediately preceded by the hand-computed pval_t derivation. Accurate.

_subfiles/Linear-models-overview/_sec_linreg_wald.qmd:104This also matches.This calculated interval also matches. Correct: immediately preceded by the confint_t computation. Accurate.

chapters/parametric-survival-models.qmd:648Of the packages belowOf the following packages. This resolves the "below" reference to the immediately-following bullet list. Note the CLAUDE.md rule technically prescribes @label cross-referencing instead of a positional word, but the referenced content is a plain (unlabeled) bullet list of package names — there's no {#...} anchor to cross-reference, so "following" is a reasonable, low-risk substitute for "below" here. Not a blocking issue, just noting the rule wasn't satisfied to the letter (no @label was introduced) because no labelable target exists.

No bugs, no math changes (so the macro-opportunity check doesn't apply — nothing added/changed in $...$ or display math in this diff), no code/citation/API references that could be hallucinated, no _subfiles/ heading violations, and no changes affecting render-profile wiring. These are pure sentence-level prose clarifications; rendered content is otherwise unaffected (no line-wrap-only or formatting-only concerns to flag).

I checked git show origin/main:<path> for all three files to confirm the "before" text this diff modifies still matches current main (i.e., this isn't stale/already-fixed by the superficially similarly-titled, already-merged PR #1162 — that commit added these files fresh with the same unfixed demonstratives still present, so this PR is not redundant).

No d-morrison/macros submodule/macros.qmd was found in this repo (this repo uses latex-macros/macros.qmd per its own CLAUDE.md, and I confirmed no math was touched in the diff regardless), so the macro-simplification/new-macro checks don't apply to this change.

This is Jules-authored (not Claude), open, not a draft, and no prior Claude review comment exists on the PR — this is the first review.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "2fb49350e7c8726b9f8a56647c87ea98c93330fd",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Reviewed all three changed files (two Linear-models-overview subfiles, one survival-models chapter) and found each demonstrative-referent substitution grammatically and contextually accurate against surrounding prose, with no logic, rendering, or reference-target defects introduced.",
  "holistic_assessment": "Confirmed via origin/main comparison that this prose-clarity change is not duplicated by the similarly-titled already-merged PR #1162, stays within the CLAUDE.md-mandated demonstrative-noun-phrase requirement, and touches no code, math, citations, or render-profile wiring needing further validation."
}

Reviewed commit: 2fb4935

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3179 (review) — run

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
🚀 Preview available at: https://d-morrison.github.io/rme/pr-preview/pr-1167/

Built to branch gh-pages at 2026-09-13 21:16 UTC.

Copy link
Copy Markdown
Owner

Closing as a duplicate. This PR is one of seven automated dem-extra1 (Jules) PRs that ran the same "improve narrative flow / clarify demonstrative referents / fix heading levels" sweep with heavy file and content overlap (#1172, #1171, #1168, #1167, #1166, #1164, #1163). Rather than driving all seven through review separately for the same defects, #1168 (the largest/most complete sweep) is being kept and driven to merge. Content this PR touches that #1168 doesn't cover is tracked in #1174.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants