Skip to content

Improve narrative flow, correct mistakes, and clarify heading levels - #1168

Merged
d-morrison merged 3 commits into
mainfrom
jules-1265817913684440933-66bfff0e
Sep 17, 2026
Merged

d-morrison merged 3 commits into
mainfrom
jules-1265817913684440933-66bfff0e

Conversation

@dem-extra1

Copy link
Copy Markdown
Collaborator

Improved narrative flow and clarified noun phrases across subfiles and main chapters, demoted headings inside div blocks to level 4 (####), and fixed slidebreak shortcode usage.


PR created automatically by Jules for task 1265817913684440933 started by @dem-extra1

- Replace bare demonstratives and vague transitions with explicit noun phrases across chapters and subfiles
- Demote section headings inside theorem/definition/example divs to level 4 (####) to preserve document outline structure and numbering
- Fix slidebreak shortcode usage in probability subfile

Co-authored-by: dem-extra1 <112029334+dem-extra1@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…c line breaks

- Replace bare demonstratives and vague transitions with explicit noun phrases across chapters and subfiles
- Demote section headings inside theorem/definition/example divs to level 4 (####) to preserve document outline structure and numbering
- Fix slidebreak shortcode usage in probability subfile
- Enforce semantic line breaks after semicolons to pass check-new-line-breaks CI check

Co-authored-by: dem-extra1 <112029334+dem-extra1@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Owner

🔧 Claiming this PR: consolidating the 7 duplicate dem-extra1 narrative-flow/heading-level sweeps into this one (the largest/most complete). Merged main in to clear the "behind" state (main had advanced via #1173's CI fix). The other six (#1172, #1171, #1167, #1166, #1164, #1163) are closed as duplicates; uncovered content from them is tracked in #1174. Driving this PR to clean and watching it through merge.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


Review: d-morrison/rme#1168

PR status confirmed: open, unmerged (per authoritative API state passed into this run).

What changed since the last review round: I verified the computed range eefe60d0..11e5bfb6 directly with git diff --stat and git log. It touches only two .github/workflows/ files (_check-ai-tells-bypass-reusable.yml, check-ai-tells.yml), introduced by commit 681ecbc ("ci: fix stalled PRs by bypassing check-ai-tells cleanly (#1173)"). I confirmed 681ecbc is already an ancestor of origin/main (git merge-base --is-ancestor 681ecbc origin/main → yes) — it's a separate, already-merged main-branch commit that landed on the PR branch only because of the routine Merge remote-tracking branch 'origin/main' into <branch> housekeeping commit, not new content authored for this PR. Since that commit is identical on both sides of the merge base, it produces no net diff between this PR and main — which is exactly why .claude-review-pr.diff (the actual PR-vs-base diff) contains zero .github/ hunks and only the previously-reviewed .qmd prose/heading changes.

I read the full .claude-review-pr.diff (718 lines) end-to-end and confirmed every hunk in it — the ##/####### heading-level fixes across data.qmd, estimation.qmd, exploratory-descriptive.qmd, inference.qmd, coxph-model-building.qmd, count-vars.qmd, and the various _subfiles/; the ---{{< slidebreak >}} swap in _def-cond-expectation-function.qmd; and the "that is"/bare "This is" prose rewordings — matches content already covered and found clean across the two prior review rounds (8c6e260 and eefe60d0). No genuinely new content-diff exists in this round for me to review.

Since the CI-workflow commit that produced this round's re-trigger is infra-only, came from main, and produces zero net diff against the PR's base, CLAUDE.md's "Workflow / .github/ / CI / infra changes go in their own dedicated PRs" rule doesn't apply here — it wasn't authored as part of this PR's changeset, it's just merge-commit noise from keeping the branch current with main.

The most recent prior review — posted 2026-09-14T21:47:47Z, run 34900579149, reviewing commit eefe60d09b635cd4fd982c7f5eed6e20ee588608 — concluded Ready for merge with no findings, and explicitly noted that the original full-content review (posted 2026-09-14T21:32:40Z, run 34899078524, commit 8c6e26017240653b300d29a74624ace5f88f9f6e) also found the diff clean (heading-level fixes correctly scoped inside theorem divs, the slidebreak swap correct, prose rewordings accurate and grammatically sound, no macro/citation/hallucination issues). Both verdicts still stand — this round introduces no new PR content to invalidate them.

No macros submodule check was newly needed: no math was added or changed in this round's diff (confirmed above — zero net PR-vs-base diff beyond what was already reviewed, and the earlier rounds already established no math changes exist in this PR at all).

Verdict

Ready for merge — no new findings; this round's only diff is main-branch CI housekeeping that nets to zero against the PR's actual content, and the prior rounds' full-content review (both concluding CLEAN) still stands.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "11e5bfb6cf14a1a1057481319930756878c5a157",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Confirmed via git diff --stat and merge-base ancestry check that the eefe60d0..11e5bfb6 range only touches two already-merged-to-main workflow files, producing zero net content diff against the PR base.",
  "holistic_assessment": "Scope remains confined to previously reviewed prose and heading-level fixes; no regression, integration, or validation concern arises from the CI housekeeping merge commits in this round."
}

Reviewed commit: 07afef6

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3518 (review) — run

Copy link
Copy Markdown
Owner

✅ Fully clean: all 18 checks green (including the quarto render, which just finished), review verdict CLEAN across 3 rounds, mergeable_state: clean. Ready for merge whenever you'd like.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-09-17 19:53 UTC

@d-morrison
d-morrison merged commit b542176 into main Sep 17, 2026
18 checks passed
@d-morrison
d-morrison deleted the jules-1265817913684440933-66bfff0e branch September 17, 2026 18:53
dem-extra1 added a commit that referenced this pull request Sep 21, 2026
… covered by #1168 (#1183)

* start: apply narrative-flow/demonstrative-referent cleanup (closes #1174)

* fix: apply narrative-flow and demonstrative-referent cleanup (closes #1174)

* fix(review): preserve dual antecedent and polish table phrasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants