-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[dagster-airlift] Move around classes #29154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dpeng817/fix_prop
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@property | ||
def finished(self) -> bool: | ||
from dagster_airlift.core.airflow_instance import TERMINAL_STATES | ||
return self.state in TERMINAL_STATES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a circular import issue here: airflow_instance.py
imports from runtime_representations.py
and now runtime_representations.py
imports from airflow_instance.py
.
To resolve this, consider either:
- Moving
TERMINAL_STATES
to a common module that both can import - Defining
TERMINAL_STATES
inruntime_representations.py
and importing it inairflow_instance.py
instead - Passing
TERMINAL_STATES
as a parameter when creatingDagRun
instances
This will maintain clean dependency structure and prevent potential import-time issues.
@property | |
def finished(self) -> bool: | |
from dagster_airlift.core.airflow_instance import TERMINAL_STATES | |
return self.state in TERMINAL_STATES | |
@property | |
def finished(self) -> bool: | |
from dagster_airlift.core.constants import TERMINAL_STATES | |
return self.state in TERMINAL_STATES |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
6454c96
to
b6e1161
Compare
d9dd539
to
6c9d753
Compare
b6e1161
to
89bae05
Compare
6c9d753
to
72b6c4a
Compare
89bae05
to
b657a5a
Compare
72b6c4a
to
9c99114
Compare
b657a5a
to
ea90ba9
Compare
9c99114
to
485ea40
Compare
ea90ba9
to
6deb8db
Compare
485ea40
to
1bb7131
Compare
6deb8db
to
c2a259c
Compare
Summary & Motivation
This file was getting too big and is about to get bigger. Move around non-serialized airflow representations to a different file.
How I Tested These Changes
Existing tests