[dagster-airlift] Move around classes #29154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
28
to
31
| @property | ||
| def finished(self) -> bool: | ||
| from dagster_airlift.core.airflow_instance import TERMINAL_STATES | ||
| return self.state in TERMINAL_STATES |
There was a problem hiding this comment.
There's a circular import issue here: airflow_instance.py imports from runtime_representations.py and now runtime_representations.py imports from airflow_instance.py.
To resolve this, consider either:
- Moving
TERMINAL_STATESto a common module that both can import - Defining
TERMINAL_STATESinruntime_representations.pyand importing it inairflow_instance.pyinstead - Passing
TERMINAL_STATESas a parameter when creatingDagRuninstances
This will maintain clean dependency structure and prevent potential import-time issues.
Suggested change
| @property | |
| def finished(self) -> bool: | |
| from dagster_airlift.core.airflow_instance import TERMINAL_STATES | |
| return self.state in TERMINAL_STATES | |
| @property | |
| def finished(self) -> bool: | |
| from dagster_airlift.core.constants import TERMINAL_STATES | |
| return self.state in TERMINAL_STATES |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/runtime_representations
branch
from
6454c96 to
b6e1161
Compare
This was referenced Apr 9, 2025
[dagster-airlift][jobs 1/n] move assets def construction to common code path; other refactors
#29206
Merged
dpeng817
force-pushed
the
dpeng817/fix_prop
branch
from
d9dd539 to
6c9d753
Compare
dpeng817
force-pushed
the
dpeng817/runtime_representations
branch
from
b6e1161 to
89bae05
Compare
prha
approved these changes
Apr 15, 2025
This was referenced Apr 15, 2025
OwenKephart
approved these changes
Apr 16, 2025
This was referenced Apr 16, 2025
Closed
This was referenced Apr 25, 2025
Closed
dpeng817
force-pushed
the
dpeng817/fix_prop
branch
from
1bb7131 to
297627f
Compare
dpeng817
force-pushed
the
dpeng817/runtime_representations
branch
from
c2a259c to
d6b9022
Compare
This was referenced Apr 30, 2025
Merged
Merged
dpeng817
force-pushed
the
dpeng817/fix_prop
branch
from
297627f to
8b11fcc
Compare
dpeng817
force-pushed
the
dpeng817/runtime_representations
branch
from
d6b9022 to
afa68dc
Compare
dpeng817
force-pushed
the
dpeng817/fix_prop
branch
from
8b11fcc to
736b731
Compare
dpeng817
force-pushed
the
dpeng817/runtime_representations
branch
from
afa68dc to
e7ac036
Compare
…ce retrieval methods (#29155) ## Summary & Motivation Adds storage classes + retrieval methods to the AirflowInstance for airflow datasets. Based on the Airflow rest API which can be found here: https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html ## How I Tested These Changes New kitchen sink test
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 9cdfa18. |
This was referenced May 2, 2025
This was referenced May 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This file was getting too big and is about to get bigger. Move around non-serialized airflow representations to a different file.
How I Tested These Changes
Existing tests