[dagster-airlift][jobs 1/n] move assets def construction to common code path; other refactors #29206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2025
Open
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 11, 2025
dpeng817
changed the title
This was referenced Apr 12, 2025
dpeng817
force-pushed
the
dpeng817/dataset_filtering
branch
from
3c88083 to
3812316
Compare
dpeng817
force-pushed
the
dpeng817/dont_force_assets_def_construction
branch
from
6418df4 to
a8adeb9
Compare
OwenKephart
approved these changes
Apr 15, 2025
This was referenced Apr 15, 2025
Closed
Closed
This was referenced Apr 17, 2025
dpeng817
force-pushed
the
dpeng817/dataset_filtering
branch
from
3812316 to
28ea70e
Compare
dpeng817
force-pushed
the
dpeng817/dont_force_assets_def_construction
branch
from
a8adeb9 to
069b2f1
Compare
dpeng817
force-pushed
the
dpeng817/dataset_filtering
branch
from
28ea70e to
ae9608c
Compare
dpeng817
force-pushed
the
dpeng817/dont_force_assets_def_construction
branch
from
069b2f1 to
b8c34f5
Compare
dpeng817
force-pushed
the
dpeng817/dataset_filtering
branch
from
ae9608c to
730f322
Compare
dpeng817
force-pushed
the
dpeng817/dont_force_assets_def_construction
branch
from
b8c34f5 to
85ec7f4
Compare
dpeng817
force-pushed
the
dpeng817/dataset_filtering
branch
from
730f322 to
ccef52b
Compare
dpeng817
force-pushed
the
dpeng817/dont_force_assets_def_construction
branch
from
85ec7f4 to
13aecf2
Compare
dpeng817
force-pushed
the
dpeng817/dataset_filtering
branch
from
ccef52b to
fb6bb06
Compare
dpeng817
force-pushed
the
dpeng817/dont_force_assets_def_construction
branch
from
13aecf2 to
103cae3
Compare
This was referenced Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Right now we're separately coercing specs to assets definitions across many different code paths. Instead consolidate into a single code path.
Additionally, get rid of the build_defs method on the state loader. We're not using it, we're instead pulling state out of thin air using get_or_fetch_state.
How I Tested These Changes
Existing tests