-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[dagster-airlift][jobs 5/n][RFC] Airflow monitoring job #29277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dpeng817
wants to merge
1
commit into
defs_execute_in_process
Choose a base branch
from
dpeng817/dpeng817/monitoring_job_real
base: defs_execute_in_process
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[dagster-airlift][jobs 5/n][RFC] Airflow monitoring job #29277
dpeng817
wants to merge
1
commit into
defs_execute_in_process
from
dpeng817/dpeng817/monitoring_job_real
+977
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2025
Open
This was referenced Apr 15, 2025
python_modules/libraries/dagster-airlift/dagster_airlift/core/monitoring_job/event_stream.py
Show resolved
Hide resolved
a7caf6a
to
05fb3ae
Compare
431a600
to
cdf963d
Compare
05fb3ae
to
bbb6263
Compare
cdf963d
to
84e01c1
Compare
python_modules/libraries/dagster-airlift/dagster_airlift/core/monitoring_job/event_stream.py
Outdated
Show resolved
Hide resolved
84e01c1
to
ab1be69
Compare
OwenKephart
approved these changes
Apr 15, 2025
python_modules/libraries/dagster-airlift/dagster_airlift/core/airflow_instance.py
Show resolved
Hide resolved
python_modules/libraries/dagster-airlift/dagster_airlift/core/monitoring_job/event_stream.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-airlift/dagster_airlift/core/monitoring_job/event_stream.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-airlift/dagster_airlift/core/monitoring_job/event_stream.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-airlift/dagster_airlift/core/monitoring_job/event_stream.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-airlift/dagster_airlift/core/utils.py
Outdated
Show resolved
Hide resolved
OwenKephart
previously requested changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just req'ing changes as i had some comments but overall I think this approach makes sense
This was referenced Apr 15, 2025
This was referenced Apr 16, 2025
Closed
Closed
bbb6263
to
6595ca7
Compare
ab1be69
to
9aad18e
Compare
9aad18e
to
ebeb4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR introduces a new monitoring job for dagstser-airlift that tracks Airflow runs as Dagster runs. The monitoring job polls the Airflow instance for activity and inserts new events and runs into the db.
How I Tested These Changes