Skip to content

[dagster-airlift][jobs 5/n][RFC] Airflow monitoring job #29277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: defs_execute_in_process
Choose a base branch
from

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Apr 15, 2025

Summary & Motivation

This PR introduces a new monitoring job for dagstser-airlift that tracks Airflow runs as Dagster runs. The monitoring job polls the Airflow instance for activity and inserts new events and runs into the db.

How I Tested These Changes

  • Added comprehensive unit tests for the monitoring job functionality
  • Live-tested with kitchen sink to ensure that runs were properly picked up.

Copy link
Contributor Author

dpeng817 commented Apr 15, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dpeng817 dpeng817 changed the title [dagster-airlift][jobs 5/n] Airflow monitoring job [RFC][dagster-airlift][jobs 5/n] Airflow monitoring job Apr 15, 2025
@dpeng817 dpeng817 requested review from OwenKephart and prha April 15, 2025 01:37
@dpeng817 dpeng817 marked this pull request as ready for review April 15, 2025 01:37
@dpeng817 dpeng817 force-pushed the defs_execute_in_process branch from a7caf6a to 05fb3ae Compare April 15, 2025 16:35
@dpeng817 dpeng817 force-pushed the dpeng817/dpeng817/monitoring_job_real branch from 431a600 to cdf963d Compare April 15, 2025 16:35
@dpeng817 dpeng817 force-pushed the defs_execute_in_process branch from 05fb3ae to bbb6263 Compare April 15, 2025 17:04
@dpeng817 dpeng817 force-pushed the dpeng817/dpeng817/monitoring_job_real branch from cdf963d to 84e01c1 Compare April 15, 2025 17:04
@dpeng817 dpeng817 force-pushed the dpeng817/dpeng817/monitoring_job_real branch from 84e01c1 to ab1be69 Compare April 15, 2025 18:14
Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just req'ing changes as i had some comments but overall I think this approach makes sense

@dpeng817 dpeng817 force-pushed the dpeng817/dpeng817/monitoring_job_real branch from 9aad18e to ebeb4d2 Compare April 18, 2025 17:59
@dpeng817 dpeng817 requested a review from OwenKephart April 18, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants