Add core definitions and API for partitioned asset checks #32894
+221
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 22, 2025
prha
force-pushed
the
prha/asset-checks-01-storage
branch
from
ad1ad53 to
d40db50
Compare
prha
force-pushed
the
prha/asset-checks-02-definitions
branch
2 times, most recently
from
1b1f86d to
ae24dca
Compare
prha
force-pushed
the
prha/asset-checks-01-storage
branch
2 times, most recently
from
29cfe1c to
fa787f5
Compare
prha
force-pushed
the
prha/asset-checks-02-definitions
branch
2 times, most recently
from
4258d4d to
0e1644c
Compare
prha
force-pushed
the
prha/asset-checks-01-storage
branch
from
4fcf31d to
7e13c5c
Compare
prha
force-pushed
the
prha/asset-checks-02-definitions
branch
3 times, most recently
from
eba7469 to
5a33220
Compare
This PR adds the core API layer for partitioned asset checks: - Add partitions_def field to AssetCheckSpec - Update asset_check decorator to support partitions_def parameter - Add partition_key property to AssetCheckExecutionContext - Update AssetCheckEvaluation and AssetCheckResult to include partition info - Add event definitions for partitioned check evaluations - Update external data representation for remote execution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
prha
force-pushed
the
prha/asset-checks-02-definitions
branch
from
5a33220 to
33ba92c
Compare
…onsDefinition and MultiPartitionsDefinition
Fixed issue where DynamicPartitionsDefinition.has_partition_key was being
called without the required dynamic_partitions_store parameter, causing
tests to fail with "The instance is not available to load partitions" error.
Changes:
1. Updated MultiPartitionsDefinition.has_partition_key to accept current_time
and dynamic_partitions_store parameters, passing them through to
DynamicPartitionsDefinition dimensions
2. Updated run_domain._get_planned_partitions to pass dynamic_partitions_store
when checking has_partition_key for both DynamicPartitionsDefinition and
MultiPartitionsDefinition
This ensures dynamic partitions can access the instance to load partition keys,
whether they're used directly or as dimensions in multi-partitions.
Fixes: test_dynamic_partitioned_run, test_unfetched_partitioned_events_are_unconsumed,
test_assets (dynamic_asset_partitions)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog