Refactor UI components for shared partition status display#32897
Open
prha wants to merge 1 commit into
Open
Conversation
This was referenced Nov 22, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 22, 2025
prha
marked this pull request as ready for review
November 22, 2025 04:02
Contributor
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit c5b07e4. |
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
November 22, 2025 06:25
eec13c8 to
628e6a7
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
2 times, most recently
from
November 22, 2025 19:50
9fb5bd3 to
ec88c00
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
November 22, 2025 19:50
628e6a7 to
0e641c0
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
November 22, 2025 20:26
ec88c00 to
0abb3cf
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
November 22, 2025 20:26
0e641c0 to
609aa4a
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
November 22, 2025 20:31
0abb3cf to
9de7d5a
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
2 times, most recently
from
November 22, 2025 20:49
a08eaf6 to
8c51a66
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
2 times, most recently
from
November 22, 2025 22:01
131d77c to
92c7290
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
November 22, 2025 22:01
8c51a66 to
f119c4f
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
November 22, 2025 22:51
92c7290 to
e23bbee
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
November 22, 2025 22:51
f119c4f to
4afe4c1
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
November 22, 2025 23:06
e23bbee to
da8ded6
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
2 times, most recently
from
November 22, 2025 23:52
6b40bc9 to
d265c63
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
2 times, most recently
from
November 23, 2025 00:32
9732a46 to
b5b9078
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
November 23, 2025 00:32
d265c63 to
5b22b78
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
November 23, 2025 02:50
b5b9078 to
a6173b9
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
November 23, 2025 02:50
5b22b78 to
baa2baf
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
November 23, 2025 03:21
a6173b9 to
93049b2
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
2 times, most recently
from
November 23, 2025 05:32
60485fc to
e2222b9
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
December 2, 2025 00:31
e2222b9 to
8cb02e9
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
December 2, 2025 00:31
f4618a3 to
61785e0
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
December 3, 2025 21:51
8cb02e9 to
d48d07b
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
December 3, 2025 21:51
61785e0 to
74c64f1
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
December 3, 2025 22:15
d48d07b to
8781b50
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
December 3, 2025 22:15
74c64f1 to
0139201
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
December 4, 2025 22:23
0139201 to
7b37459
Compare
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
2 times, most recently
from
December 5, 2025 05:56
deeeaa2 to
8a0f0fe
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
December 5, 2025 05:56
7b37459 to
4e2ab18
Compare
hellendag
approved these changes
Dec 5, 2025
| const rowVirtualizer = useVirtualizer({ | ||
| count: partitions.length, | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| getItemKey: (idx) => partitions[idx]!, |
Contributor
There was a problem hiding this comment.
It would be nice to avoid the non-null assertion here. partitions[idx] ?? idx would probably be fine. (I know this is copied from elsewhere, but while we're here it would be great to clean up the non-null assertions.)
This PR extracts shared UI components for partition status display: - Extract PartitionListSelector from AssetPartitionList for reuse - Extract PartitionStatusCheckboxes from AssetPartitionStatusCheckboxes - Refactor AssetPartitionList to use shared PartitionListSelector - Refactor AssetPartitionStatusCheckboxes to use shared checkboxes - Update client.json configuration These components will be reused by asset check partition UI in the next PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
prha
force-pushed
the
prha/asset-checks-05-ui-refactor
branch
from
December 5, 2025 18:22
8a0f0fe to
c5b07e4
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
December 5, 2025 18:22
4e2ab18 to
5eda9eb
Compare
Merged
OwenKephart
added a commit
that referenced
this pull request
Jan 26, 2026
## Summary & Motivation changes copied from: #32897 ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Extracted some UI components to be reused for both asset materialization history and asset check evaluation history
How I Tested These Changes
BK