Add GraphQL schema and resolvers for partitioned asset checks #32896
+659
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2025
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 22, 2025
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit f4618a3. |
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
from
4213f4b to
a913f96
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
2 times, most recently
from
9fb5bd3 to
ec88c00
Compare
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
from
a913f96 to
abc217b
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
ec88c00 to
0abb3cf
Compare
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
2 times, most recently
from
e38d765 to
6d3c5ff
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
2 times, most recently
from
9de7d5a to
131d77c
Compare
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
from
6d3c5ff to
012ba9e
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
131d77c to
92c7290
Compare
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
from
012ba9e to
7c85971
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
92c7290 to
e23bbee
Compare
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
from
7c85971 to
25f28ca
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
e23bbee to
da8ded6
Compare
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
2 times, most recently
from
5dde55b to
cc9e6f0
Compare
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
3 times, most recently
from
b5b9078 to
a6173b9
Compare
This PR adds the GraphQL layer for partitioned asset checks: - Add partitionsDefinition field to GraphQL AssetCheck type - Add AssetCheckPartitionStatus type for partition-level status tracking - Add resolver for assetCheckPartitionStatuses query - Update asset graph schema to expose check partition information - Add partition filtering to asset check execution history queries - Generate TypeScript types for UI consumption 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
prha
force-pushed
the
prha/asset-checks-04-graphql
branch
from
a6173b9 to
93049b2
Compare
prha
force-pushed
the
prha/asset-checks-03-asset-graph
branch
from
82ecfd9 to
dae6172
Compare
Added comprehensive tests for retrieving asset check executions for partitioned assets via GraphQL: 1. test_partitioned_asset_check_executions - Tests basic partition support for asset checks - Creates check executions for multiple partitions - Verifies both IN_PROGRESS and completed (SUCCEEDED/FAILED) statuses - Validates evaluation metadata and descriptions per partition 2. test_partitioned_asset_check_executions_with_partition_filter - Tests the partition filter parameter in assetCheckExecutions query - Creates checks for different time-based partitions (2024-01, 2024-02) - Verifies filtering works correctly to isolate specific partition executions - Tests both filtered and unfiltered queries These tests ensure the GraphQL API correctly handles partitioned asset checks, which is essential for querying check status on a per-partition basis. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The AssetCheckEvaluation class has a partition field that needs to be set when storing evaluation events for partitioned asset checks. This field is used by the storage layer to properly associate evaluations with their partitions, enabling partition-based filtering in the GraphQL API. Changes: - Added partition parameter to AssetCheckEvaluation in test events - This ensures evaluations are properly linked to their partitions - All partition filter tests now pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| MultiPartitionsSnap, | ||
| ), | ||
| ): | ||
| if start_idx and end_idx and isinstance(partitions_snap, TimeWindowPartitionsSnap): |
Contributor
There was a problem hiding this comment.
This condition will incorrectly evaluate to False when start_idx is 0, preventing users from querying partitions starting at index 0.
if start_idx is not None and end_idx is not None and isinstance(partitions_snap, TimeWindowPartitionsSnap):The truthiness check (if start_idx and end_idx) treats 0 as falsy, so start_idx=0 will be ignored. This should use explicit is not None checks instead.
Suggested change
| if start_idx and end_idx and isinstance(partitions_snap, TimeWindowPartitionsSnap): | |
| if start_idx is not None and end_idx is not None and isinstance(partitions_snap, TimeWindowPartitionsSnap): |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog