refactor: nix-files feedback reusing git status, eliminate resulting dead code#278
Merged
Merged
Conversation
Collaborator
Author
2 tasks
Contributor
📋 PR Overview
🔬 Coverage
|
Copilot started reviewing on behalf of
Scott McMaster (scottmcmaster)
June 2, 2026 08:37
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors feedback collection for “changed nix files” to reuse the git2-based git::query::status() implementation, and removes the now-dead CLI diff helpers/tests from the git exec layer.
Changes:
- Removes
git::get_nix_diff(and its helper functions/tests) fromgit/exec.rs. - Adds a feedback-local
get_nix_diff()that derives.nixdiffs fromgit::status().changes. - Updates unit tests to cover the new diff-gathering path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/native/src-tauri/src/git/mod.rs | Stops re-exporting the removed get_nix_diff from the git exec surface. |
| apps/native/src-tauri/src/git/exec.rs | Deletes unused nix-diff generation helpers and their associated unit tests. |
| apps/native/src-tauri/src/feedback.rs | Reimplements nix diff gathering via git::status() and adds/updates tests for the new behavior. |
869c5fd to
f0289b8
Compare
This was referenced Jun 3, 2026
a79b67d to
c8dbe68
Compare
c8dbe68 to
d9a6fb9
Compare
This was referenced Jun 3, 2026
Closed
Juanpe Bolívar (arximboldi)
approved these changes
Jun 3, 2026
Juanpe Bolívar (arximboldi)
left a comment
Contributor
There was a problem hiding this comment.
Nice!
834dc3b to
0c09458
Compare
d9a6fb9 to
c9e6df7
Compare
Base automatically changed from
06-03-scott-fix-made-edit-or-build-check
to
develop
June 4, 2026 11:52
cooper (czxtm)
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Rewrite the feedback gathering for nix file diffs to reuse the revamped git::query::status, then get rid of all the code that deads, thereby avoiding having to port it to git2.
Test Plan
Updated and added unit tests.
Docs
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.