refactor: port the git log function from CLI to git2#281
Closed
Scott McMaster (scottmcmaster) wants to merge 3 commits into
Closed
refactor: port the git log function from CLI to git2#281Scott McMaster (scottmcmaster) wants to merge 3 commits into
Scott McMaster (scottmcmaster) wants to merge 3 commits into
Conversation
2 tasks
Collaborator
Author
2 tasks
Contributor
📋 PR Overview
🔬 Coverage
|
Copilot started reviewing on behalf of
Scott McMaster (scottmcmaster)
June 3, 2026 02:41
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Ports commit history retrieval from the Git CLI subprocess approach to native git2-based querying, and includes incidental rustfmt cleanup across several Rust files.
Changes:
- Switched history/summarization pipelines to call
crate::git::query::log(...)instead ofcrate::git::log(...). - Implemented a new
git2-backedlog()inapps/native/src-tauri/src/git/query.rswith a unit test. - Removed the old CLI-based
log()implementation and applied formatting-only cleanups in a few modules.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/native/src-tauri/src/summarize/pipelines/history.rs | Updates summarization history pipeline to use the new git2 log query. |
| apps/native/src-tauri/src/shared_types/system.rs | Removes trailing whitespace line (format-only). |
| apps/native/src-tauri/src/history/get_history.rs | Updates history query to use the new git2 log query. |
| apps/native/src-tauri/src/git/query.rs | Adds git2 implementation of log() plus a unit test. |
| apps/native/src-tauri/src/git/mod.rs | Stops re-exporting the removed CLI log() function from exec. |
| apps/native/src-tauri/src/git/exec.rs | Removes the CLI-based log() implementation and an unused helper method. |
| apps/native/src-tauri/src/evolve/search_packages.rs | Formatting-only changes (line wrapping). |
| apps/native/src-tauri/src/evolve/providers/ollama.rs | Formatting-only changes (line wrapping). |
| apps/native/src-tauri/src/commands/settings_io.rs | Removes stray blank lines (format-only). |
| apps/native/src-tauri/src/commands/permissions.rs | Removes trailing whitespace line (format-only). |
Closed
3 tasks
db44420 to
cef6666
Compare
a79b67d to
c8dbe68
Compare
77ec990 to
eebaeab
Compare
c8dbe68 to
d9a6fb9
Compare
This was referenced Jun 3, 2026
Closed
Juanpe Bolívar (arximboldi)
approved these changes
Jun 3, 2026
Juanpe Bolívar (arximboldi)
left a comment
Contributor
There was a problem hiding this comment.
So much nicer! 👏
d9a6fb9 to
c9e6df7
Compare
1af9231 to
9e77908
Compare
cooper (czxtm)
approved these changes
Jun 4, 2026
5175c7c to
269a451
Compare
Contributor
Merge activity
|
269a451 to
7b94871
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Moved the
logfunction for git from the CLI subprocess to modern git2 native rust code.It also seems like there are a bunch of rustfmt errors on the
developbranch right now that got auto-fixed.Test Plan
New unit testing for this.
Docs
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.