Skip to content

refactor: remove git stash command and related functionality#291

Closed
Scott McMaster (scottmcmaster) wants to merge 1 commit into
06-03-scott-improve-create_evolution_backupfrom
06-03-scott-kill-git-stash
Closed

refactor: remove git stash command and related functionality#291
Scott McMaster (scottmcmaster) wants to merge 1 commit into
06-03-scott-improve-create_evolution_backupfrom
06-03-scott-kill-git-stash

Conversation

@scottmcmaster

@scottmcmaster Scott McMaster (scottmcmaster) commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

git stash functionality and wiring appears to not be used, which is really good because I think this was going to be a big roadblock if we want to be able to get rid of command-line git deps.

Test Plan

  • No test plan needed

Docs

  • Docs updated (companion PR in darkmatter/nixmac-web: #___)
  • No docs update needed

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Scott McMaster (scottmcmaster) commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • automerge - adds this PR to the back of the merge queue
  • urgent - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@scottmcmaster Scott McMaster (scottmcmaster) changed the title scott-kill-git-stash refactor: remove git stash command and related functionality Jun 3, 2026
@scottmcmaster Scott McMaster (scottmcmaster) marked this pull request as ready for review June 3, 2026 08:05

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted code makes me happy :)

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

📋 PR Overview

Lines changed 45 (+5 / -40)
Files 0 added, 7 modified, 0 deleted
Draft / WIP no
Has Test Plan no
No Test Plan Needed yes
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 26.3% 26.5% 24.3% 17.9%

Generated by 🚫 dangerJS against 8ea959e

@czxtm cooper (czxtm) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@graphite-app

graphite-app Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Merge activity

  • Jun 5, 12:29 AM UTC: czxtm added this pull request to the Graphite merge queue.
  • Jun 5, 12:30 AM UTC: CI is running for this pull request on a draft pull request (#318) due to your merge queue CI optimization settings.
  • Jun 5, 12:33 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #281.
  • Jun 5, 12:33 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #281.
  • Jun 5, 1:30 AM UTC: czxtm added this pull request to the Graphite merge queue.
  • Jun 5, 1:31 AM UTC: CI is running for this pull request on a draft pull request (#321) due to your merge queue CI optimization settings.
  • Jun 5, 1:37 AM UTC: Merged by the Graphite merge queue via draft PR: #321.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants