Int32 repro & ConstantTime #579

Merged

thehoul merged 81 commits into

int32-reviewedfrom

Dec 16, 2025

ValeriodeSa commented Jul 24, 2025 •

edited by thehoul

Loading

Contributor

Depends on #582

Note

Add a constant-time build mode with a new big-int backend, refactor code/tests behind build tags, switch DKG/VSS/DSS to uint32 indices, and update CI, lint, and coverage to support both modes.

Core/Crypto:
- Introduce constant-time build mode (constantTime) with a new compatible big-integer backend (compatible/bigmod) and assembly accelerators; gate existing variable‑time code/tests behind !constantTime.
- Refactor suites: constant-time exports limited, variable‑time suites moved to *_vartime.go.
Protocols/Types:
- Standardize indices/thresholds to uint32 across DKG/VSS/DSS and related APIs; fix range and index handling.
- Minor API cleanups (e.g., direct []kyber.Point use in anon, mask ops, recovery functions).
Tests/Benchmarks:
- Add/adjust tests and benchmarks for both modes (incl. BLS12‑381 fixtures); split vartime tests with build tags.
CI/Tooling:
- Expand test matrix to run with/without constantTime; aggregate coverage from both; revamp lint config; minor Makefile/log tweaks; ignore *.bck.yml.

^{Written by Cursor Bugbot for commit 01aac07. This will update automatically on new commits. Configure here.}

github-actions Bot commented Jul 24, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

7 similar comments

github-actions Bot commented Aug 5, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 11, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 11, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 15, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 18, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 18, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 18, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

AnomalRoil reviewed

View reviewed changes

AnomalRoil left a comment

Contributor

a few comments, including outdated ones

.github/workflows/tests.yml

.golangci.bck.yml Outdated

.golangci.yml

Makefile

Makefile Outdated

util/random/rand_test.go Outdated

suites/all.go Outdated

share/poly_test.go Outdated

share/dkg/rabin/dkg_test.go

pairing/bls12381/gnark/g2.go

github-actions Bot commented Aug 19, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

4 similar comments

github-actions Bot commented Aug 20, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 20, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Aug 26, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

github-actions Bot commented Sep 8, 2025

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

pierluca added the safe PR label

pierluca marked this pull request as ready for review

November 7, 2025 08:27

cursor Bot reviewed

View reviewed changes

cursor Bot left a comment

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

shuffle/pair.go

jbsv changed the base branch from master to constantFirstPart

November 10, 2025 16:22

thehoul mentioned this pull request

Constant first part #582

Closed

thehoul reviewed

View reviewed changes

docs/scalar.md

thehoul force-pushed the constantFirstPart branch from 014b88a to dd5d437 Compare

November 14, 2025 09:16

thehoul force-pushed the int32-repro branch 2 times, most recently from 94d6ec6 to 1fbefbf Compare

November 14, 2025 11:59

thehoul force-pushed the constantFirstPart branch from dd5d437 to f1fd094 Compare

November 17, 2025 08:37

thehoul force-pushed the int32-repro branch from 1fbefbf to b0faa50 Compare

November 17, 2025 11:37

CLAassistant commented Nov 17, 2025 •

edited

Loading

All committers have signed the CLA.

thehoul force-pushed the constantFirstPart branch 2 times, most recently from 71995d3 to 919fa0b Compare

November 17, 2025 12:14

thehoul force-pushed the int32-repro branch from b0faa50 to aeaa107 Compare

November 17, 2025 12:20

thehoul mentioned this pull request

Int32 repro original #581

Merged

thehoul added 2 commits

December 11, 2025 11:39


          rename comptabile_mod to compatiblemod (lint complaint)

ffcee46

rename comptabile_mod to compatiblemod (lint complaint)


          update compatible_test.go

783b398

thehoul force-pushed the int32-repro branch from be7c3fa to 783b398 Compare

December 11, 2025 10:40

thehoul added 2 commits

December 11, 2025 12:19


          fix tag use in test workflow

697de7b


          change test workflow to use pull_request and not pull_request_target

d0f6e28

thehoul mentioned this pull request

Constant time #591

Closed


          fix test workflow and add int32-repro to targets

3d40429

github-advanced-security AI found potential problems

View reviewed changes

compatible/bigmod/extra_test.go Fixed

thehoul added 19 commits

December 12, 2025 10:53


          revert to pull_request_target

26cc493


          change rsa to 2048 bit key in bigmod test for sonar security rating

de3349e


          fix Mul() in const_int

f4fbea4


          fix todo in group/edwards25519/fe.go

517f0eb


          fix scalar_vartime_test.go

4e919e2


          remove todo that will be fixed elsewhere

ea81c68


          remove astwalk/prova.go

dd89993


          fix SetBytesMod in const_int.go to avoid small buffer revealing value…

84c36d8

… byte size


          update go.mod

96aad77


          add const/var time files for variables to avoid benchmark code duplic…

db3acf9

…ation


          remove constant/vartime benchmark duplication in ecies

3050e1e


          remove constant_scalar.go

19747f2


          remove todo previously fixed

c5b15bb


          add Int64() and Uint64() missing from constant_time_int.go and add tests

b0b1811


          add Uint64() missing from const_int.go and add test for Int64() and U…

6c8515d

…int64()


          remove todo and redundant code in constant_time_int.go

9f63521


          remove cirl.BLS12381 from constant time suites


          fix calls to create a modulus from bigInt creating an unnecessary tem…

455ebe5

…porary Int

fix calls to create a modulus from bigInt creating an unnecessary temporary Int

simplify test


          remove NewModulusFromNat() as it makes public a dangerous method (see F…

1da9247

…iloSottile/bigmod#2)

thehoul merged commit 9e5a693 into int32-reviewed

15 of 24 checks passed

thehoul deleted the int32-repro branch

December 16, 2025 16:27

thehoul mentioned this pull request

Fix package in asm generator #598

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels