build!: replace forked solana-* crates by latest releases
#197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
force-pushed
the
lpahlavi/remove-solana-sdk-fork
branch
from
cd25d7b to
b01aeb8
Compare
lpahlavi
force-pushed
the
lpahlavi/remove-solana-sdk-fork
branch
from
d0cfe0e to
2e5d8fa
Compare
lpahlavi
changed the title
solana-sdksolana-sdk
lpahlavi
changed the title
solana-sdksolana-sdk by latest releases
lpahlavi
changed the title
solana-sdk by latest releasessolana-* crates by latest releases
lpahlavi
changed the title
solana-* crates by latest releasessolana-* crates by latest releases
Merged
Collaborator
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @lpahlavi for cleaning this up!
gregorydemay
approved these changes
Aug 22, 2025
lpahlavi
added a commit
that referenced
this pull request
Aug 22, 2025
(XC-297) This is a follow-up to #197. Now that the `solana-sdk` dependencies are upgraded to v3, use the `spl_associated_token_account_interface` crate to compute associated token addresses (ATAs) and `spl-token-interface` crate to create an SPL transfer instruction in the `basic_solana` example and integration tests.
lpahlavi
added a commit
that referenced
this pull request
Sep 1, 2025
## 🤖 New release * `sol_rpc_types`: 2.0.0 -> 3.0.0 * `sol_rpc_canister`: 1.1.0 -> 1.2.0 * `sol_rpc_client`: 2.0.0 -> 3.0.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `sol_rpc_types` <blockquote> ## [3.0.0](sol_rpc_types-v2.0.0...sol_rpc_types-v3.0.0) - 2025-08-29 ### Changed - Replace forked `solana-*` crates by the corresponding ones in `solana_sdk` version `3.0.0`. The `patch.crates-io` section in `Cargo.toml` is therefore no longer necessary and can be removed. ([#197](#197)) </blockquote> ## `sol_rpc_canister` <blockquote> ## [1.2.0](sol_rpc_canister-v1.1.0...sol_rpc_canister-v1.2.0) - 2025-08-29 ### Changed - Replace forked `solana-*` crates by the corresponding ones in `solana_sdk` version `3.0.0`. The `patch.crates-io` section in `Cargo.toml` is therefore no longer necessary and can be removed. ([#197](#197)) </blockquote> ## `sol_rpc_client` <blockquote> ## [3.0.0](sol_rpc_client-v2.0.0...sol_rpc_client-v3.0.0) - 2025-08-29 ### Changed - Replace forked `solana-*` crates by the corresponding ones in `solana_sdk` version `3.0.0`. The `patch.crates-io` section in `Cargo.toml` is therefore no longer necessary and can be removed. ([#197](#197)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <[email protected]>
lpahlavi
added a commit
that referenced
this pull request
Sep 2, 2025
([XC-456](https://dfinity.atlassian.net/browse/XC-456)) Due to the breaking changes in #197, the symlink for the `basic_solana` ICP Ninja deployment source code was removed. Since `sol_rpc_client` and `sol_rpc_types` v3.0.0 were released without the patched `solana-*` dependencies, this PR adds back the symlink and removes the duplicated code for the `basic_solana` ICP Ninja deployment. [XC-456]: https://dfinity.atlassian.net/browse/XC-456?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-297) This PR updates all
solana-*crates to their latest v3 releases, which introduce breaking changes.solana-*crates no longer depend onwasm-bindgen. This eliminates the need for our custom forks ofsolana-sdkandsolana-system-program. As a result, all[patch.crates-io]sections have been removed fromCargo.tomlfiles.basic_solanauses the latest published version ofsol_rpc_clienton crates.io. That version still depends on the older v2solana-*crates. To accommodate this, the ICP Ninja deployment is temporarily branched from the local and mainnet deployments, which now use the v3 crates.BREAKING CHANGES: This update is breaking for the
sol_rpc_typesandsol_rpc_clientcrates, as they re-export many types from thesolana-*crates.