[Engine] Cleanup Store code#7424
Conversation
|
I think I'll submit a PR separately that changes the variable names found in stores.cpp so this PR is much easier to review. |
|
I think you should, this one already has conflicts despite being the latest |
34b6132 to
705e5f6
Compare
|
Do your self a favor and merge master rather then rebase on it with the commits you have. |
95cd85b to
3e5daee
Compare
a69ea18 to
1243405
Compare
|
|
||
| void SetActiveStore(TalkID talkId) | ||
| { | ||
| OldActiveStore = ActiveStore; |
There was a problem hiding this comment.
Sort of. Next and Previous are inverse of each other, while Old is like "Last", but not in the context of being inverse of first. I kept it as Old to prevent confusion with terminology.
There was a problem hiding this comment.
Example:
int OldScrollPos; // Remember last scroll position
int ScrollPos; // Scroll position
int NextScrollPos; // Next scroll position
int PreviousScrollPos; // Previous scroll position```
|
There appears to be a critical issue with selling items. I noticed that sometimes the correct amount of gold is received, and other times the complete wrong amount is received. EDIT: Fixed! |
c57e410 to
77ddb0b
Compare
ac673f4 to
b1bcead
Compare
|
4 files have conflicts |
Also fixes a minor bug with text display
b1bcead to
58f0b48
Compare
No description provided.