fix: resolve four bugs in execution, module, context, and workflow - #154
Merged
FernandoCelmer merged 4 commits intoApr 7, 2026
Merged
Conversation
- execution.py: use == instead of is for string module comparison (dotflow-io#135) - context.py: accept str in workflow_id setter by converting to UUID (dotflow-io#136) - module.py: use module.__name__ as sys.modules key instead of module object (dotflow-io#137) - workflow.py: whitelist valid execution modes before calling getattr (dotflow-io#138)
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
==instead ofisfor string module comparison (BUG: Module comparison uses 'is' instead of '==' for strings #135)strinworkflow_idsetter by converting toUUID(BUG: workflow_id type mismatch between str and UUID #136)module.__name__assys.moduleskey instead of module object (BUG: sys.modules uses module object as key instead of string name #137)getattr(self, mode)(BUG: No mode whitelist — getattr allows calling arbitrary methods #138)Motivation and Context
Four isolated bug fixes for issues found during core audit. Each fix addresses a correctness or safety issue in the execution pipeline.
Closes #135, #136, #137, #138
Types of changes
Checklist