-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HybridCache public API #55084
Add HybridCache public API #55084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions but it seems generally good to me. @halter73?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits about readability and coding conventions we use
Co-authored-by: Brennan <[email protected]>
Co-authored-by: Brennan <[email protected]>
Co-authored-by: Brennan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw a typo while reading the reviews
DisableUndelyingData => DisableUnderlyingData
I did not check all references just did a quick find on github
src/Caching/Hybrid/src/Runtime/IHybridCacheSerializerFactory.cs
Outdated
Show resolved
Hide resolved
@halter73 have I addressed all of your concerns? |
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
Co-authored-by: Brennan <[email protected]> Co-authored-by: joegoldman2 <[email protected]>
@joegoldman2 thanks for all the great documentation tweaks |
All issue feedback has been addressed, and I've invited additional @halter73 - I'm interpreting existing tick plus silence as "fine"; merging; happy to make additional tweaks as required, but would rather hit next preview and then have a break, than not hit the next preview |
This is the final proposed API for HybridCache (#54647) as discussed #54647
The implementation is a placeholder (that just invokes the backend service every time, i.e. no cache), and exists purely to test (via the tests project) that:
ConfigurationBinder
GetOrCreateAsync
APIs can be used through code (in particular with implicit generic typing)The code incorporates the changes and feedback from #54647
The bits that we anticipate pushing to runtime are in a sub-folder, but are in their intended namespaces.