-
Notifications
You must be signed in to change notification settings - Fork 64
[22850] Fix python code generation for bounded strings #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
9 tasks
richiware
requested changes
Feb 25, 2025
Signed-off-by: Miguel Company <[email protected]>
richiware
approved these changes
Feb 25, 2025
@Mergifyio backport 4.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
* Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <[email protected]> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 8eaca9a)
MiguelCompany
added a commit
that referenced
this pull request
Feb 26, 2025
* Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <[email protected]> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 8eaca9a) Co-authored-by: Miguel Company <[email protected]>
@Mergifyio backport 3.3.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <[email protected]> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 8eaca9a) # Conflicts: # src/main/java/com/eprosima/fastcdr/idl/templates/TypesSwigInterface.stg
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following improvements on the code generated for SWIG interfaces:
fixed_string
members receiving a standard string is added.%template
for each fixed_string member is generated.This allows setting bounded string members with either of the following alternatives:
struct_name.member_name("string value")
@Mergifyio backport 4.0.x
Contributor Checklist
Reviewer Checklist