Skip to content

[23264] Add DataWriter sample prefilter documentation#1077

Merged
MiguelCompany merged 4 commits into
masterfrom
feature/dw/sample-prefilter
Jun 12, 2025
Merged

[23264] Add DataWriter sample prefilter documentation#1077
MiguelCompany merged 4 commits into
masterfrom
feature/dw/sample-prefilter

Conversation

@Mario-DL

@Mario-DL Mario-DL commented Jun 4, 2025 •
edited by MiguelCompany
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the proper documentation of the corresponding feature in Fast DDS

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL
Refs #23264: Add prefilter feature documentation
230a8b1 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.3.0 milestone Jun 4, 2025
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 4, 2025 10:41
@Mario-DL Mario-DL mentioned this pull request Jun 4, 2025
Closed
14 tasks
@Mario-DL
Refs #23264: Update due to impl review
3d398a1 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 9, 2025 12:54
@Mario-DL Mario-DL mentioned this pull request Jun 9, 2025
Merged
14 tasks
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 9, 2025 15:03
@Mario-DL
Refs #23264: Add Miguel's advice
a2b3bfb 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 10, 2025 13:45
MiguelCompany
MiguelCompany requested changes Jun 11, 2025
View reviewed changes
Comment thread code/DDSCodeTester.cpp
Comment thread docs/fastdds/dds_layer/publisher/dataWriter/publishingData.rst Outdated
@Mario-DL
Refs #23264: Apply Miguel's review
be0ae9f 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 11, 2025 09:31
@MiguelCompany
MiguelCompany merged commit 4b8d976 into master Jun 12, 2025
3 checks passed
@MiguelCompany
MiguelCompany deleted the feature/dw/sample-prefilter branch June 12, 2025 06:09
@Mario-DL Mario-DL mentioned this pull request Jun 12, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@Mario-DL @MiguelCompany