Skip to content

[23264] Feature: DataWriter sample prefilter#5848

Closed
Mario-DL wants to merge 8 commits into
masterfrom
feature/dw/sample-prefilter
Closed

[23264] Feature: DataWriter sample prefilter#5848
Mario-DL wants to merge 8 commits into
masterfrom
feature/dw/sample-prefilter

Conversation

@Mario-DL

@Mario-DL Mario-DL commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Description

This PR brings the prefiltering feature in the DataWriter. This operation lets user to filter out destination readers from a particular sample based on the SerializedPayload and/or WriteParams by implementing the IContentFilter interface.

It also extends the FilteredSampleInfo and the WriteParams structures to include a new member UserWriteData meant to be extended by the user.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Mario-DL added 4 commits June 3, 2025 15:34
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.3.0 milestone Jun 3, 2025
@Mario-DL Mario-DL added doc-pending Issue or PR which is pending to be documented versions-pending labels Jun 3, 2025
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL removed doc-pending Issue or PR which is pending to be documented versions-pending labels Jun 4, 2025
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 4, 2025 10:46
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 4, 2025
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 4, 2025 12:28
@Mario-DL
Mario-DL force-pushed the feature/dw/sample-prefilter branch 2 times, most recently from 49756ef to 26de35f Compare June 4, 2025 14:41
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 4, 2025 14:41
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL force-pushed the feature/dw/sample-prefilter branch from 26de35f to 093554e Compare June 4, 2025 21:29
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 4, 2025 21:29
@Mario-DL
Mario-DL force-pushed the feature/dw/sample-prefilter branch from 5c6197f to acdc890 Compare June 5, 2025 07:14
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 5, 2025 07:16
@Mario-DL
Mario-DL force-pushed the feature/dw/sample-prefilter branch from acdc890 to 08f6c3c Compare June 5, 2025 07:33
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 5, 2025 07:35
Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL force-pushed the feature/dw/sample-prefilter branch from 08f6c3c to 3bda8b0 Compare June 5, 2025 09:30
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 5, 2025 09:30
Comment thread include/fastdds/dds/topic/IContentFilter.hpp Outdated
Comment thread include/fastdds/dds/publisher/DataWriter.hpp Outdated
Comment thread test/blackbox/api/dds-pim/PubSubWriter.hpp Outdated
Comment thread test/blackbox/common/DDSBlackboxTestsContentFilter.cpp Outdated
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 9, 2025 12:49
@Mario-DL Mario-DL closed this Jun 9, 2025
@Mario-DL
Mario-DL deleted the feature/dw/sample-prefilter branch June 9, 2025 14:54
@Mario-DL
Mario-DL restored the feature/dw/sample-prefilter branch June 9, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants