Skip to content

[23264] Feature: DataWriter sample prefilter#5861

Merged
MiguelCompany merged 10 commits into
masterfrom
feature/dw/sample-prefilter
Jun 12, 2025
Merged

[23264] Feature: DataWriter sample prefilter#5861
MiguelCompany merged 10 commits into
masterfrom
feature/dw/sample-prefilter

Conversation

@Mario-DL

@Mario-DL Mario-DL commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Description

This PR brings the prefiltering feature in the DataWriter. This operation lets user to filter out destination readers from a particular sample based on the SerializedPayload and/or WriteParams by implementing the IContentFilter interface.

It also extends the FilteredSampleInfo and the WriteParams structures to include a new member UserWriteData meant to be extended by the user.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.3.0 milestone Jun 9, 2025
@Mario-DL Mario-DL changed the title [23264] Feature: DataWriter sample prefilter [23264] Feature: DataWriter sample prefilter Jun 9, 2025
@MiguelCompany
MiguelCompany self-requested a review June 9, 2025 14:57
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 9, 2025
Mario-DL added 8 commits June 10, 2025 11:25
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL force-pushed the feature/dw/sample-prefilter branch 2 times, most recently from 4e0f285 to ab99135 Compare June 10, 2025 09:28
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 10, 2025 09:38
…DataWriterImpl Always registered as implementor of reader_data_filters()

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL force-pushed the feature/dw/sample-prefilter branch from ab99135 to f4e972f Compare June 10, 2025 13:31
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 10, 2025 13:36
Comment thread src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated
Comment thread src/cpp/fastdds/publisher/DataWriterImpl.cpp
Comment thread src/cpp/fastdds/publisher/DataWriterImpl.cpp
Comment thread test/blackbox/common/DDSBlackboxTestsDataWriter.cpp
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 11, 2025 09:32

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
MiguelCompany merged commit 6af234a into master Jun 12, 2025
15 of 16 checks passed
@MiguelCompany
MiguelCompany deleted the feature/dw/sample-prefilter branch June 12, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants