metricbeat: ensure event.duration field is not discarded on Windows #44442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set.
mauri870
added
cleanup
Team:Elastic-Agent-Data-Plane
botelastic
bot
added
needs_team
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
mauri870
added
backport-8.17
mauri870
changed the title
mauri870
changed the title
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
pierrehilbert
requested review from
faec and
leehinman
and removed request for
khushijain21 and
rdner
8 tasks
mauri870
force-pushed
the
event-duration-windows-zero
branch
from
6856bef to
32f6b57
Compare
mauri870
force-pushed
the
event-duration-windows-zero
branch
from
487ad2d to
04a7578
Compare
leehinman
approved these changes
May 23, 2025
faec
approved these changes
May 23, 2025
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2025
…44442) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b)
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2025
…44442) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b)
Merged
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2025
…44442) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b)
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2025
…44442) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b)
Merged
6 tasks
mauri870
added a commit
that referenced
this pull request
May 23, 2025
…t discarded on Windows (#44453) * metricbeat: ensure event.duration field is not discarded on Windows (#44442) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> Co-authored-by: Pierre HILBERT <[email protected]>
mauri870
added a commit
that referenced
this pull request
May 23, 2025
…44442) (#44455) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870
added a commit
that referenced
this pull request
May 23, 2025
…44442) (#44454) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870
added a commit
that referenced
this pull request
May 23, 2025
… discarded on Windows (#44456) * metricbeat: ensure event.duration field is not discarded on Windows (#44442) * metricbeat: ensure event.duration field is not discarded on Windows Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end may be below this resolution, resulting in a zero duration. A zero event duration is interpreted as absence of value and discarded when setting event fields. This commit ensures a minimum duration is always set. * linter fixes * use rand.N * add changelog (cherry picked from commit 7839c6b) * Update CHANGELOG.next.asciidoc * fix signature of module.NewWrapper --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> Co-authored-by: Pierre HILBERT <[email protected]>
|
For anyone landing here from: While they work on golang/go#67066 you can use https://github.com/loov/hrtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Windows, starting with Go 1.23+, provides high-resolution timers, but the effective clock resolution remains around 0.5 ms. When event processing is very fast, the elapsed time between start and end timestamps may be less than this resolution, resulting in a diff of zero.
A zero event duration is interpreted as absence of value and discarded when setting event fields.
This commit ensures a minimum duration is set to preserve event.duration in the ingested event.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues