Skip to content

otel: support system/metrics input with experimental otel runtime #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented May 14, 2025

What does this PR do?

This PR enables the system/metrics input to work with the otel runtime. It needs to be toggled explicitly by setting _runtime_experimental: otel in the input configuration.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@mauri870 mauri870 self-assigned this May 14, 2025
@mauri870 mauri870 added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels May 14, 2025
Copy link
Contributor

mergify bot commented May 14, 2025

This pull request does not have a backport label. Could you fix it @mauri870? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mauri870 mauri870 force-pushed the otel-system-metrics branch from eb0ee7f to 62c4e7b Compare May 14, 2025 13:21
@mauri870 mauri870 added skip-changelog backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch labels May 14, 2025
@mauri870 mauri870 marked this pull request as ready for review May 14, 2025 13:32
@mauri870 mauri870 requested a review from a team as a code owner May 14, 2025 13:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 force-pushed the otel-system-metrics branch from 62c4e7b to 12ea09f Compare May 14, 2025 15:59
@mauri870 mauri870 marked this pull request as draft May 19, 2025 14:19
@mauri870 mauri870 marked this pull request as ready for review May 20, 2025 13:03
@mauri870 mauri870 force-pushed the otel-system-metrics branch from 98b18a7 to b7612b0 Compare May 20, 2025 14:43
@mauri870 mauri870 force-pushed the otel-system-metrics branch from ea11818 to 8f57a30 Compare May 20, 2025 17:47
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestAgentMetricsInput had a flaky run here @mauri870 , so please have a look. The only this that comes to mind is that when this was retried it provisioned an isolated ESS stack so please do make sure that there is no interference when TestAgentMetricsInput is running in parallel from multiple runners

@swiatekm
Copy link
Contributor

TestAgentMetricsInput had a flaky run here @mauri870 , so please have a look. The only this that comes to mind is that when this was retried it provisioned an isolated ESS stack so please do make sure that there is no interference when TestAgentMetricsInput is running in parallel from multiple runners

That looks like the system.network.in.errors metric doesn't always appear in the output.

@mauri870 I think what we should actually check is that the documents have the same fields, but not that the values are the same. Just ignoring all the fields containing metrics makes this test not very useful.

@mauri870 mauri870 marked this pull request as draft May 21, 2025 11:28
@mauri870 mauri870 force-pushed the otel-system-metrics branch from 49c5f9d to 1ee22f1 Compare May 21, 2025 17:12
Copy link

@elasticmachine
Copy link
Contributor

elasticmachine commented May 22, 2025

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @mauri870

@mauri870
Copy link
Member Author

mauri870 commented May 23, 2025

Found during testing that event.duration is sometimes missing from the ingested document with beats receivers on Windows. Pushed a fix in elastic/beats#44442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants