-
Notifications
You must be signed in to change notification settings - Fork 168
otel: support system/metrics input with experimental otel runtime #8148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @mauri870? 🙏
|
eb0ee7f
to
62c4e7b
Compare
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
62c4e7b
to
12ea09f
Compare
98b18a7
to
b7612b0
Compare
ea11818
to
8f57a30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestAgentMetricsInput had a flaky run here @mauri870 , so please have a look. The only this that comes to mind is that when this was retried it provisioned an isolated ESS stack so please do make sure that there is no interference when TestAgentMetricsInput is running in parallel from multiple runners
That looks like the @mauri870 I think what we should actually check is that the documents have the same fields, but not that the values are the same. Just ignoring all the fields containing metrics makes this test not very useful. |
49c5f9d
to
1ee22f1
Compare
2652c38
to
ea8a07c
Compare
|
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @mauri870 |
Found during testing that |
What does this PR do?
This PR enables the system/metrics input to work with the otel runtime. It needs to be toggled explicitly by setting
_runtime_experimental: otel
in the input configuration.Checklist
./changelog/fragments
using the changelog toolRelated issues