Deliver payload types in order that they were received

[bidetofevil]

Goal

Ensure payloads of a single type are delivered in order. This required some initial refactoring to simplify the streamline the threading and payload queuing model before this could work without problematic race conditions (that existed at least in the integration tests).

Major changes include:

• Using a dedicated worker for the scheduling thread and consolidating the finding and queuing of the next payload delivery to that
  • This simplifies the "delivery loop" so we always bounce back to the scheduling thread for the payload finding/queuing, thus avoiding annoying race conditions and error scenarios.
• Debouncing new delivery attempts from payload in takes and retries
• Synchronize payload delete update with the actual deletion done by the PayloadStorageService, as the real implementation does the deletion async
• Use blocking mode for executors in unit tests to better orchestrate and verify execution order

There's a bunch of renaming, code consolidation, and tracer updates as well.

[bidetofevil]

• Deliver payload types in order that they were received #3160 : 2 dependent PRs (#3161 , #3163 ) 👈 (View in Graphite)
• Block sending of non-crash payloads on resurrection #3159
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[fractalwrench]

LGTM once CI is passing

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.00%. Comparing base (b637ff0) to head (a1b4b91).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...esdk/internal/delivery/debug/DeliveryTraceState.kt	21.73%	18 Missing ⚠️
...ernal/delivery/scheduling/SchedulingServiceImpl.kt	93.10%	1 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3160      +/-   ##
==========================================
+ Coverage   77.89%   78.00%   +0.10%     
==========================================
  Files         558      558              
  Lines       11931    11973      +42     
  Branches     1782     1793      +11     
==========================================
+ Hits         9294     9339      +45     
+ Misses       1927     1924       -3     
  Partials      710      710              

Files with missing lines	Coverage Δ
...mbracesdk/internal/injection/DeliveryModuleImpl.kt	91.56% <100.00%> (ø)
...bracesdk/internal/delivery/debug/DeliveryTracer.kt	87.50% <100.00%> (+1.13%)	⬆️
...brace/android/embracesdk/internal/worker/Worker.kt	100.00% <100.00%> (ø)
...ernal/delivery/scheduling/SchedulingServiceImpl.kt	93.37% <93.10%> (+3.50%)	⬆️
...esdk/internal/delivery/debug/DeliveryTraceState.kt	56.00% <21.73%> (+0.89%)	⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fractalwrench]

LGTM once CI is passing

[bidetofevil]

Merge activity

• Mar 30, 5:20 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Mar 30, 5:22 PM UTC: Graphite rebased this pull request as part of a merge.
• Mar 30, 5:23 PM UTC: @bidetofevil merged this pull request with Graphite.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a1b4b91.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None