Add CI check for uncommitted changes by "make all"#525
Merged
Acepresso merged 1 commit intoMay 22, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
=====================================
Coverage 0.55% 0.55%
=====================================
Files 6 6
Lines 363 363
=====================================
Hits 2 2
Misses 361 361
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
In order to test the new CI, I created #528 with uncommitted changes by |
simonbaird
reviewed
May 19, 2025
joejstuart
reviewed
May 20, 2025
Acepresso
force-pushed
the
pre-merge-make-all-EC-1262
branch
from
2f382ae to
aea473c
Compare
simonbaird
approved these changes
May 21, 2025
Member
|
Looks like it needs some commit signing. |
Currently, `make test` is used to detect uncommitted file changes, but it missed some targets that modify files (e.g. "make docs"). Update the workflow to also run `make all`, to ensure that all relevant file-generating targets are executed before checking for uncommitted changes. Refs: https://issues.redhat.com/browse/EC-1262
Acepresso
force-pushed
the
pre-merge-make-all-EC-1262
branch
from
aea473c to
ca0759c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check fails pre-merge if there are uncommitted changes generated during
make allexecution.Refs: https://issues.redhat.com/browse/EC-1262