You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Documents the decision (already in effect since PR #5180) to publish the Tokens Studio pipeline output under temporary additive ./next/{css,dtcg,ts}/* subpaths during the eds-tokens beta, injected into files/exports at publish time — instead of replacing the legacy build on the final specifiers immediately, or asking testers to install two package versions side by side.
Contents
documentation/adr/0009-temporary-next-subpaths-for-eds-tokens-beta.md — full context, the three options considered, and the exit plan: when the last /next component has migrated to the new variable names, a beta release drops the legacy build/ output and moves the Tokens Studio output onto the final specifiers — inside the beta line, before graduation, so at least one beta exposes the exact 3.0.0 export surface.
.github/workflows/publish_tokens.yaml — the comment above the publish-time injection now describes the full lifecycle and links the ADR.
packages/eds-tokens/src/tokens/README.md — same lifecycle note and ADR link for anyone reading the generated-output docs.
One open decision is called out in the ADR's consequences: the final specifier layout (granular ./css/* only, or also a bundled convenience entry) must be settled before the flip.
Review: docs — ADR for temporary next/* subpaths during eds-tokens beta
Docs/comments-only PR. I read the diff and verified every factual claim and cross-reference against the repo.
Verification results — all pass:
ADR numbering — 0009 is the next free number; 0008 exists, no collision.
Header format (Status / Date / Decision makers) matches the ADR template and sibling ADRs (0007, 0008).
ADR-0008 reference resolves — title "Generate TypeScript tokens by combining the Tokens Studio DTCG and CSS exports", consistent with the "how the TS output under next/ts/* is generated" description.
README relative link ../../../../documentation/adr/0009-… — 4 hops from packages/eds-tokens/src/tokens/README.md lands at repo root; matches the depth of the existing TOKENS_STUDIO.md link right below it. Correct.
"the exports map in git stays legacy-only" — confirmed: package.jsonexports has ./css/variables → ./build/css/variables.min.css and no ./next/* entries.
publish_tokens.yaml comment is accurate to the injection it sits above and now links the ADR.
Assessment
This is a clean, well-structured ADR. The three options are laid out fairly (each with genuine pros and cons rather than strawmen), the decision drivers tie directly into the chosen option, and — importantly — it captures the exit plan and the one remaining open decision (bundled convenience entry vs. granular ./css/* only) rather than leaving them implicit. Documenting an already-in-effect decision (#5180) retroactively is appropriate here and the PR body is upfront about it.
Minor observations (non-blocking, optional)
Status: Accepted vs. an open sub-decision. The consequences list the final specifier layout as still-open ("must be made before the flip"). Accepted is right for the additive-subpaths decision itself, so this is fine — just worth confirming that follow-up gets its own tracking (an issue link, or a future ADR) so the open item doesn't get lost. Everything needed to pick it up later is captured here, so this is a nicety, not a gap.
Related section link styles are mixed. ADR-0008 and the README/TOKENS_STUDIO entries use Markdown links, while publish_tokens.yaml is bare inline code. Intentional (it's not a linkable doc from within the repo docs site the same way), and harmless — flagging only for consistency-minded reviewers.
Illustrative variable names (--eds-background-container-*, --eds-density-spacing-*, --eds-family-ui) in the Context section are examples, not an exhaustive contract — reads clearly as such, no change needed.
Verdict
No correctness, accessibility, or convention issues. Cross-references and paths are all valid. The two observations above are optional polish. Ship-ready as documentation. ✅
• docs/adr-tokens-beta-export-surface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the decision (already in effect since PR #5180) to publish the Tokens Studio pipeline output under temporary additive
./next/{css,dtcg,ts}/*subpaths during the eds-tokens beta, injected intofiles/exportsat publish time — instead of replacing the legacy build on the final specifiers immediately, or asking testers to install two package versions side by side.Contents
documentation/adr/0009-temporary-next-subpaths-for-eds-tokens-beta.md— full context, the three options considered, and the exit plan: when the last/nextcomponent has migrated to the new variable names, a beta release drops the legacybuild/output and moves the Tokens Studio output onto the final specifiers — inside the beta line, before graduation, so at least one beta exposes the exact 3.0.0 export surface..github/workflows/publish_tokens.yaml— the comment above the publish-time injection now describes the full lifecycle and links the ADR.packages/eds-tokens/src/tokens/README.md— same lifecycle note and ADR link for anyone reading the generated-output docs.Notes
./css/*only, or also a bundled convenience entry) must be settled before the flip.