fix: upload non-version tagged release artifacts#64
Closed
sdwilsh wants to merge 1 commit intofacebook:mainfrom
sdwilsh:non-versioned-releases
Closed
fix: upload non-version tagged release artifacts#64sdwilsh wants to merge 1 commit intofacebook:mainfrom sdwilsh:non-versioned-releases
sdwilsh wants to merge 1 commit intofacebook:mainfrom
sdwilsh:non-versioned-releases
Conversation
Our Dev Container feature, today, uses the GitHub REST API in order to figure out the correct "latest" release. However, this can be rate limited, and in fact, we've had some of our tests fail for that exact reason. We cannot use the magic `latest` URL to fetch artifacts because the version number is also in the artifact. Therefore, we must start to upload artifacts without version numbers as well. This also makes a change with the non-versioned artifacts to use `uname -m`-compatible architecture suffixes.
Contributor
|
@sdwilsh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
Summary: We got this wrong in #64, and automation merged it before I could fix it. Reviewed By: bigfootjon Differential Revision: D77190788 fbshipit-source-id: af6e12cc9e52391c4b91f2ecf6b409f286344b8d
This was referenced Jun 25, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…#62) Summary: This does a few things: - Uses versionless artifacts to avoid rate limits of the GitHub API (which we can do now that #64 has been merged) - Adds CI for arm (+ publishes a dev container since our CI needs it for arm) - Adds a test when specifying a version Pull Request resolved: #62 Reviewed By: bigfootjon Differential Revision: D77389154 Pulled By: sdwilsh fbshipit-source-id: aa67a7cf7a8bf73a64eee6ba53f7128ebb66a6c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Dev Container feature, today, uses the GitHub REST API in order to figure out the correct "latest" release. However, this can be rate limited, and in fact, we've had some of our tests fail for that exact reason. We cannot use the magic
latestURL to fetch artifacts because the version number is also in the artifact. Therefore, we must start to upload artifacts without version numbers as well.This also makes a change with the non-versioned artifacts to use
uname -m-compatible architecture suffixes.