Expanded reset logic for Simulator #2451
Merged
Merged
Conversation
…bject states, set light setup default key to scene's light key
facebook-github-bot
added
the
CLA Signed
jturner65
reviewed
Aug 16, 2024
Comment on lines
+685
to
+691
| // set the default light key to reference the scene's light setup | ||
| auto initSceneInstanceAttr = | ||
| metadataMediator_->getSceneInstanceAttributesManager() | ||
| ->getObjectCopyByHandle(curSceneInstanceAttributes_->getHandle()); | ||
| auto sceneLightSetup = resourceManager_->getLightSetup( | ||
| initSceneInstanceAttr->getLightingHandle()); | ||
| resourceManager_->setLightSetup(*sceneLightSetup); |
Contributor
There was a problem hiding this comment.
This should be a lot easier. Something to revisit down the road.
jturner65
approved these changes
Aug 16, 2024
jturner65
left a comment
jturner65
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Hopefully it passes :)
…locities when no scene_instance init was provided. Also update unit test.
Open
11 tasks
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR add expanded reset logic to base Simulator:
default light setup key points to scene's light setup key(moved to Simulator.reset should change default_lighting_key to point to scene instance lighting setup #2453)This is a breaking change, previously reset only set world time to 0.
How Has This Been Tested
CI should still pass.
Added new unit test to validate the rest logic
Types of changes
Checklist