Simulator.reset should change default_lighting_key to point to scene instance lighting setup#2453
Simulator.reset should change default_lighting_key to point to scene instance lighting setup#2453aclegg3 wants to merge 1 commit into
Conversation
…stance defined light setup
|
Changed this to merge into the dev branch |
|
Hi @aclegg3! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Motivation and Context
Moved this change from #2451 for closer evaluation in isolation and unit test updates.
How Has This Been Tested
CI
TODO: requires changes to unit test GT images.
Types of changes
Checklist