Skip to content

Simulator.reset should change default_lighting_key to point to scene instance lighting setup#2453

Open
aclegg3 wants to merge 1 commit into
mainfrom
alex-08_19-sim_reset_default_lighting_from_instance
Open

Simulator.reset should change default_lighting_key to point to scene instance lighting setup#2453
aclegg3 wants to merge 1 commit into
mainfrom
alex-08_19-sim_reset_default_lighting_from_instance

Conversation

@aclegg3

@aclegg3 aclegg3 commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

Motivation and Context

Moved this change from #2451 for closer evaluation in isolation and unit test updates.

How Has This Been Tested

CI
TODO: requires changes to unit test GT images.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3
aclegg3 requested a review from jturner65 August 19, 2024 18:43
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 19, 2024
@aclegg3 aclegg3 mentioned this pull request Aug 19, 2024
11 tasks
@jturner65
jturner65 changed the base branch from main to dev September 18, 2024 17:23
@jturner65

Copy link
Copy Markdown
Contributor

Changed this to merge into the dev branch

Base automatically changed from dev to main November 4, 2024 16:35
@meta-cla

meta-cla Bot commented May 19, 2026

Copy link
Copy Markdown

Hi @aclegg3!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants