-
Notifications
You must be signed in to change notification settings - Fork 177
Firedrake meeting 2025 11 04
Date and time 2025-11-04 1600 UTC+1
- Pick Chair and Minuter (CW to pick)
- ALL: (ongoing) triage the open issues and confirm if they are indeed still open (and perhaps provide labels)
- ALL: do things with SV's branches
- DH: Email to Andreas to have 2 (+ others!!!) loopy PRs merged TODO: FIND OUT WHICH PRS THESE ARE
- DH: Talk to GregVernon about PR#2116.
- CW: More testing configurations (minutes)
- LC: Add self to authors list
Present:
Apologies:
FIAT #183 (+46,-19), Firedrake #4684 (+96,-17), Firedrake #4658 (+15), Firedrake #4430 (+1102,-129), and Firedrake #3478 (+2241,-516) have all been merged in the past couple of weeks without an approving review. Further, some introduced breaking changes that were not announced.
What needs to happen with https://github.com/firedrakeproject/firedrake/pull/4675? Shall we merge this ASAP and make a new patch release?
(Firedrake #3478)[https://github.com/firedrakeproject/firedrake/pull/3478] changed the return value of MixedFunctionSpace.mesh() from a Mesh to a MeshSequence. There wasn't an approval for this PR so this API change didn't get much (any?) discussion.
Its a fairly major API change that will require changes in a lot of downstream code. Are we happy with this API change?
Can we ease downstream code changes, e.g. a FunctionSpace.unique_mesh property that errors if there are multiple meshes?
https://github.com/firedrakeproject/firedrake/pull/4691
See thread. To be clear I am not suggesting we change everything now, just that we record it in our coding guide and try to enforce it for new code.
https://github.com/firedrakeproject/firedrake/pull/4582
LC: UFL interpolate argument numbering logic https://github.com/FEniCS/ufl/pull/425
1600 UTC 2025-11-11