Fix mem leak and pending pool #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2025 19:57
SozinM
force-pushed
the
msozin/mem-leak-fix
branch
from
de9d8a5 to
dfecfbf
Compare
3 tasks
3 tasks
avalonche
reviewed
May 15, 2025
| Ok(()) | ||
| } | ||
|
|
||
| /// Caution: this test could be brittle to change because of queued pool checks |
Collaborator
There was a problem hiding this comment.
what queued pool checks here would make the tests brittle?
Collaborator
Author
There was a problem hiding this comment.
there asserts
assert_eq!(
pool_content.queued.len(),
1,
"Queued pool should contain only 1 transaction"
);
If you add/remove transactions in the tests this assert will fail
avalonche
reviewed
May 15, 2025
| // to pending pool, because nonce gap would be fixed. | ||
| let mut queued_hash = None; | ||
| let mut pool_content = provider.txpool_content().await?; | ||
| if !pool_content.queued.is_empty() { |
Collaborator
There was a problem hiding this comment.
you shouldn't need the empty check here since you already have an assertion for the length of the queued transaction later
Collaborator
Author
There was a problem hiding this comment.
this assert needed on the iteration zero, when we don't have any transaction in the pool
This will store hash that is inside pending pool in case we are on the 1+ iteration
avalonche
approved these changes
May 15, 2025
Collaborator
Author
|
Merged new reth in different branch |
Collaborator
Author
|
reth on main, test in different pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Rebase on latest reth to include all fixes (for pending pool and memory leak)
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test