Fix image-based provisioning on VMware #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The failing tests are unrelated to the changes in this PR. |
nofaralfasi
force-pushed
the
fix_image_prov
branch
2 times, most recently
from
89140ea to
6c0d4f8
Compare
Collaborator
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
Can you please rebase, tests has been fixed in the #311
Add SecureBoot and VirtualTPM options for image-based provisioning on VMware
nofaralfasi
force-pushed
the
fix_image_prov
branch
from
6c0d4f8 to
18dc0d7
Compare
Gauravtalreja1
approved these changes
May 5, 2025
chris1984
approved these changes
May 5, 2025
Collaborator
|
Thanks @nofaralfasi Can we release a new version of the gem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SecureBoot and VirtualTPM options for image-based provisioning on VMware
Required for: theforeman/foreman#10524