Fixes #38381 - fix image-based provisioning on VMware #10524
Conversation
nofaralfasi
changed the title
nofaralfasi
changed the title
nofaralfasi
force-pushed
the
38381
branch
2 times, most recently
from
93c105d to
8393725
Compare
| # @return [Hash] A hash with secure boot settings if applicable. | ||
| def generate_secure_boot_settings(firmware) | ||
| firmware == 'uefi_secure_boot' ? { "secure_boot" => true } : {} | ||
| firmware == 'uefi_secure_boot' ? { secure_boot: true } : {} |
There was a problem hiding this comment.
What's the reasoning for this change?
There was a problem hiding this comment.
The reason for the change is this line:
https://github.com/theforeman/foreman/pull/10524/files#diff-be4ac4f95deb530eb0fbcc834a4940573ba45b8d5923433305ac3aa1e0703328R596
I updated it so I can use the :secure_boot symbol key consistently with the rest of the opts hash, instead of mixing it with a string key ("secure_boot" => args["secure_boot"]).
Add SecureBoot and VirtualTPM options for image-based provisioning, and for VM cloning on VMware.
Gauravtalreja1
left a comment
Gauravtalreja1
left a comment
There was a problem hiding this comment.
ACK, tested and it works as expected.
Thank you @nofaralfasi :)
|
Thanks @nofaralfasi @Gauravtalreja1 |
If you require a change in a dependency then you must also make sure to update the dependency minimum version. Otherwise you still risk users ending up in a broken situation. For example, if we cherry pick it and forget to package the dependency. |
@ekohl I made the version bump |
|
@nofaralfasi can you submit a PR that bumps the requirement to at least 3.7.1? |
Done #10537. |
5 participants
Add SecureBoot and VirtualTPM options for image-based provisioning on VMware
Requiers: fog/fog-vsphere#309