Skip to content

Update foxglove_bridge to use new ament_index API #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ericmlujan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update foxglove_bridge to use new ament_index API #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ros/src/foxglove_bridge/src/message_definition_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,12 @@ const MessageSpec& MessageDefinitionCache::load_message_spec(
}

// Get the package share directory, or throw a PackageNotFoundError
const std::string share_dir = ament_index_cpp::get_package_share_directory(package);
std::filesystem::path share_dir;
#if AMENT_INDEX_CPP_VERSION_GTE(1, 13, 0)
Copy link
Contributor Author

@ericmlujan ericmlujan Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This macro should become available after ament/ament_index#105 merges

ament_index_cpp::get_package_share_directory(package, share_dir);
#else
share_dir = ament_index_cpp::get_package_share_directory(package);
#endif

// Get the rosidl_interfaces index contents for this package
std::string index_contents;
Expand All @@ -234,7 +239,7 @@ const MessageSpec& MessageDefinitionCache::load_message_spec(
}

// Read the file
const std::string full_path = share_dir + std::filesystem::path::preferred_separator + *it;
const auto full_path = share_dir / *it;
std::ifstream file{full_path};
if (!file.good()) {
throw DefinitionNotFoundError(definition_identifier.package_resource_name);
Expand Down
Loading