Update foxglove_bridge to use new ament_index API#803
Draft
ericmlujan wants to merge 1 commit intomainfrom
Draft
Update foxglove_bridge to use new ament_index API#803ericmlujan wants to merge 1 commit intomainfrom
ericmlujan wants to merge 1 commit intomainfrom
Conversation
ericmlujan
commented
Jan 7, 2026
| // Get the package share directory, or throw a PackageNotFoundError | ||
| const std::string share_dir = ament_index_cpp::get_package_share_directory(package); | ||
| std::filesystem::path share_dir; | ||
| #if AMENT_INDEX_CPP_VERSION_GTE(1, 13, 0) |
Contributor
Author
There was a problem hiding this comment.
This macro should become available after ament/ament_index#105 merges
ericmlujan
added a commit
that referenced
this pull request
Jan 8, 2026
### Changelog None ### Docs None ### Description Temporarily suppress deprecation warnings for `get_package_share_directory`, which will cause ROS2 buildfarm builds to pass for Foxglove Bridge. These suppressions will be reverted in #803 once ament/ament_index#105 has merged and ROS packages have synced. Fixes: FLE-165 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Temporarily mutes deprecation warnings to unblock ROS2 builds. > > - Wraps `ament_index_cpp::get_package_share_directory` call in `message_definition_cache.cpp` with GCC pragmas to ignore `-Wdeprecated-declarations` > - Adds TODO noting removal after `ament_index_cpp` update (FLE-167) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 14325f4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
Just as an FYI, the upstream PR merged and is available in Jazzy, Kilted, and Rolling. We are still waiting for a Humble patch release; once that happens we should be able to move forward with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Docs
Description