fix(franka_gazebo): fix tau_ext internal controller bug
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gollth, @marcbone Similar to my previous command #226 (comment) it looks like something goes wrong in your clang checking action as it does not print the error it encounters. My local clang version does not throw any errors. |
rickstaa
force-pushed
the
fix_tau_ext_internal_controller_bug
branch
from
bbb05c1 to
d747813
Compare
Contributor
Author
rickstaa
force-pushed
the
fix_tau_ext_internal_controller_bug
branch
2 times, most recently
from
3154053 to
98d74f6
Compare
rickstaa
changed the title
tau_ext internal controller bug
1 task
rickstaa
force-pushed
the
fix_tau_ext_internal_controller_bug
branch
2 times, most recently
from
cbc6c4f to
1fb726e
Compare
Contributor
Author
|
Merging this pull request will solve #364. |
Contributor
Author
|
I've just provided an update to the associated issue (#364) with detailed steps to reproduce the bug. Please take a moment to review #288 and share your thoughts. I'd particularly appreciate your input on whether the clamped command should be considered in collision checking instead of the user command. I was unsure if you also wanted to account for internal joint interactions when checking collisions. Your feedback would be invaluable. Thank you! |
5 tasks
This commit ensures that the internal controller forces are not used in the external torque (i.e. `tau_ext`) calculation when a joint is in its limit.
rickstaa
force-pushed
the
fix_tau_ext_internal_controller_bug
branch
from
1fb726e to
a1cc0a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that internal controller forces are not used in the external torque calculations when a joint is within its
joint limits. This needs to be done since, in that case, the joint boundaries already compensate for external torques (see #364). Feel free to change this pull request however you like, as there are multiple ways to solve this problem.