Add missing install of franka_gazebo's models and world folders #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to get this merged so that all needed files are available and the documentation examples work as intended. |
1 task
rickstaa
approved these changes
Sep 1, 2023
Contributor
rickstaa
left a comment
rickstaa
left a comment
There was a problem hiding this comment.
Hey @gollth and @Maverobot,
I've reviewed this pull request, and it successfully addresses the issue reported in #360. Considering that the current state of the franka_gaebo binary includes broken examples, this fix is essential. It's preventing users from easily utilizing the examples, models and worlds your package provides.
Would it be possible to move forward and merge this pull request to ensure a smoother experience for the end users?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the Pick+Place example doesn't work from install space.