fix(franka_gazebo): fix 'set_franka_model_configuration' srv #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a problem that was introduced when https://github.com/rickstaa/franka_ros/tree/fix_gazebo_set_model_config_problem was rebased onto the `develop` branch in frankarobotics#226. The force push resulting from this rebase unfortunatelly removed the code that setsup the service.
Contributor
Author
|
@BarisYazici, just a quick note to make your review easier: the commit from the rebase that caused the issue in #226 is here. Thanks for checking this out! |
5 tasks
rickstaa
added a commit
to rickstaa/panda-gazebo
that referenced
this pull request
Mar 24, 2024
This commit updates the 'franka_ros' branch to ensure the 'set_franka_model_configuration' service is published (see frankarobotics/franka_ros#380).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a problem that was introduced when https://github.com/rickstaa/franka_ros/tree/fix_gazebo_set_model_config_problem was rebased onto the
developbranch in #226. The force push resulting from this rebase unfortunatelly removed the code that setsup the service.