UI: Adding TexturedButton2D and TextButton2D#1056
Merged
maharshi-gor merged 1 commit intofury-gl:v2from Feb 26, 2026
Merged
Conversation
ganimtron-10
force-pushed
the
v2_button
branch
from
9565c98 to
33a6db3
Compare
ganimtron-10
force-pushed
the
v2_button
branch
2 times, most recently
from
862ee11 to
6e3e6ea
Compare
ganimtron-10
force-pushed
the
v2_button
branch
from
6e3e6ea to
d0c9d89
Compare
ganimtron-10
force-pushed
the
v2_button
branch
from
d0c9d89 to
8fce415
Compare
ganimtron-10
force-pushed
the
v2_button
branch
from
8fce415 to
f281649
Compare
ganimtron-10
changed the title
ganimtron-10
force-pushed
the
v2_button
branch
from
f281649 to
862ddda
Compare
maharshi-gor
requested changes
Feb 25, 2026
Contributor
maharshi-gor
left a comment
maharshi-gor
left a comment
There was a problem hiding this comment.
Hello @ganimtron-10 thanks for the work. The PR works nicely.
Let's try to look into events binding. And some easy comments to fix.
Contributor
|
Hi @ganimtron-10 please rebase this PR. |
ganimtron-10
force-pushed
the
v2_button
branch
from
862ddda to
01d10ac
Compare
feat: adding Button2D temp: changes fix: updating buton to be reactive fix: update button icons on states fix: moving actual buttons to elements chore: adding button tests
ganimtron-10
force-pushed
the
v2_button
branch
from
01d10ac to
2f88dcc
Compare
ganimtron-10
commented
Feb 26, 2026
Comment on lines
+170
to
+171
| self.handle_events(self.child.actor) | ||
| self.handle_events(self.child.background.actor) |
Contributor
Author
There was a problem hiding this comment.
The handle_events should be refactored/rearchitected to enhance DX, maybe by allowing UI or actor or actors so that we dont need to manually specify all actors that to pickup specific events.
Contributor
Author
|
Hi @maharshi-gor, |
Contributor
|
Thanks for the changes @ganimtron-10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Button2D abstract with TexturedButton2D and TextButton2D