Skip to content

package.xml: remove mujoco for now#1000

Merged
scpeters merged 1 commit into
mainfrom
scpeters/package_xml_delist_mujoco
Jun 5, 2026
Merged

package.xml: remove mujoco for now#1000
scpeters merged 1 commit into
mainfrom
scpeters/package_xml_delist_mujoco

Conversation

@scpeters

@scpeters scpeters commented Jun 4, 2026

Copy link
Copy Markdown
Member

🦟 Bug fix

Fixes rosdep resolution for colcon CI

Summary

A recent colcon CI build for gazebosim/gz-math#780 (comment) failed during rosdep resolution:

Traceback (most recent call last):
  File "/tmp/ros_buildfarm/ros_buildfarm/scripts/ci/generate_install_lists.py", line 278, in resolve_names
# END SUBSECTION
    resolved_names = resolve_for_os(
                     ^^^^^^^^^^^^^^^
...
KeyError: 'mujoco'
...
RuntimeError: Could not resolve the rosdep key 'mujoco'

This comments out the mujoco dependency from package.xml until it has a rosdep key.

testing again with this branch:

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Delist mujoco dependency until it has a rosdep key.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Jun 4, 2026
@scpeters
scpeters merged commit 67a7d5c into main Jun 5, 2026
14 checks passed
@scpeters
scpeters deleted the scpeters/package_xml_delist_mujoco branch June 5, 2026 05:36
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Jun 5, 2026
@scpeters

scpeters commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

this should not be backported

yaswanth1701 pushed a commit to yaswanth1701/gz-physics that referenced this pull request Jun 6, 2026
Delist mujoco dependency until it has a rosdep key.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants