Extract EntityStorage to a shared location so it can be used by other physics engines#894
Extract EntityStorage to a shared location so it can be used by other physics engines#894azeey merged 3 commits intogazebosim:mainfrom
Conversation
… physics engines Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
| /// parent ID to a vector of object IDs. This is used to determine the index of | ||
| /// an entity within the container. However, if EntityStorage objects are | ||
| /// hierarchically stored in `*Info` structs, the indexInContainerToID will only | ||
| /// have one entry. See the Mujoco plugin implementation for reference. |
There was a problem hiding this comment.
nit: this comment references Mujoco though it hasn't been merged yet
There was a problem hiding this comment.
d049a67. I'll add it back with the mujoco implementation.
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
@Mergifyio backport gz-physics7 gz-physics8 gz-physics9 ign-physics5 |
✅ Backports have been createdDetails
Cherry-pick of a9ea56c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of a9ea56c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of a9ea56c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of a9ea56c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Summary
Split out of #811
The
EntityStorageclass is useful for tracking mappings between gz-physics entities and the underlying physics engine. This PR moves it out of the dartsim component and puts it in theinclude/gz/physics/detailsdirectory so that it can be used by all physics engine plugins. I put it indetailssince it is meant to be used internally by the engine plugins.This also fixes a couple of SDF warnings.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.