Add common empty-world coverage for entity management behaviors#904
Add common empty-world coverage for entity management behaviors#904XINJIANGMO wants to merge 5 commits intogazebosim:mainfrom
Conversation
Generated by : gpt-5.4-codex Signed-off-by: momo <2438833481@qq.com>
Signed-off-by: momo <2438833481@qq.com>
Signed-off-by: momo <2438833481@qq.com>
Signed-off-by: momo <2438833481@qq.com>
|
Bazel support in gz-common currently does not stably expose the so I removed the releated case in original DART test case |
Signed-off-by: momo <2438833481@qq.com>
There was a problem hiding this comment.
Pull request overview
This PR expands the existing construct_empty_world common test coverage to validate additional entity construction and removal behaviors across physics engine plugins, as part of the broader test migration effort.
Changes:
- Add common empty-world tests for manual construction of joints (revolute/prismatic) and primitive shapes (box/sphere), including basic frame-semantics checks.
- Add common tests for mesh attachment (including scaled meshes) and image heightmap attachment, including casting back to a heightmap shape.
- Add a regression guard test to prevent crashes when removing a parent model that owns nested models, and update build dependencies for the new heightmap/geospatial usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/common_test/construct_empty_world.cc |
Adds new common tests for joints/shapes, mesh/heightmap construction, and a nested-model removal crash regression guard. |
test/common_test/CMakeLists.txt |
Links the common tests against the project’s heightmap component to support new heightmap usage. |
test/BUILD.bazel |
Adds Bazel deps for //:heightmap and @gz-common//geospatial:geospatial needed by the new test code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
🎉 New feature
toward comment #299
Summary
Stage 1 for test migration :
tested in DART:
DEM heightmap attachmentTest it
Checklist
codecheckpassed (See contributing)Generated-by: gpt-5.4-codex.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.