Disable Whole Program Optimization on MSVC (backport #915)#960
Open
mergify[bot] wants to merge 2 commits into
Open
Disable Whole Program Optimization on MSVC (backport #915)#960mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
This leverages the new GZ_MSVC_WPO option in gz-cmake to globally disable Whole Program Optimization (which removes /GL and /LTCG) to significantly speed up Windows build times. Generated-By: Gemini 3.1 Pro Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> (cherry picked from commit 95c080b)
11 tasks
Disabling WPO in #915 changes how inline destructors are handled. The unregisterAtUnload hack accesses the DART factory singleton during the DLL unload phase, which causes an ABI/allocator mismatch and STATUS_HEAP_CORRUPTION on Windows. Wrapping the hack in #ifndef _WIN32 prevents this crash. Generated-by: Gemini 3.1 Pro Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This leverages the new GZ_MSVC_WPO option in gz-cmake to globally disable Whole Program Optimization (which removes /GL and /LTCG) to significantly speed up Windows build times.
Checklist
codecheckpassed (See contributing)Generated-By: Gemini 3.1 Pro
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.
This is an automatic backport of pull request #915 done by [Mergify](https://mergify.com).