Open
Conversation
9 tasks
added 8 commits
November 29, 2023 14:51
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
- Still need to add resolution to measurement and add this to the sdf format Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
henrykotze
force-pushed
the
airflow-sensor
branch
from
74e844a to
e067253
Compare
ahcorde
requested changes
Nov 29, 2023
| #ifndef GZ_SENSORS_AIRFLOWSENSOR_HH_ | ||
| #define GZ_SENSORS_AIRFLOWSENSOR_HH_ | ||
|
|
||
| #include <memory> |
| #include <memory> | ||
|
|
||
| #include <sdf/sdf.hh> | ||
|
|
Contributor
There was a problem hiding this comment.
include gz::math::Vector3d
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
|
|
||
| #include <sdf/sdf.hh> | ||
|
|
||
| #include <gz/math/Helpers.hh> |
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
azeey
reviewed
Nov 30, 2023
|
|
||
| #include <memory> | ||
|
|
||
| #include <sdf/sdf.hh> |
There was a problem hiding this comment.
Let's avoid including sdf/sdf.hh since it includes all the headers available in libsdformat, which unnecessarily increases compile time.
azeey
reviewed
Nov 30, 2023
Comment on lines
+91
to
+96
| GZ_UTILS_WARN_IGNORE__DLL_INTERFACE_MISSING | ||
| /// \brief Data pointer for private data | ||
| /// \internal | ||
| private: std::unique_ptr<AirFlowSensorPrivate> dataPtr; | ||
| GZ_UTILS_WARN_RESUME__DLL_INTERFACE_MISSING | ||
| }; |
There was a problem hiding this comment.
Can you use GZ_UTILS_IMPL_PTR instead? (see
gz-sensors/include/gz/sensors/Distortion.hh
Line 103 in ec52913
|
|
||
| #include <gtest/gtest.h> | ||
|
|
||
| #include <sdf/sdf.hh> |
There was a problem hiding this comment.
Use specific headers in sdf instead of sdf.hh.
|
|
||
| /// \brief AirFlow Sensor Class | ||
| /// | ||
| /// A sensor that reports air speed through differential pressure readings. |
There was a problem hiding this comment.
Can you update this comment and add a good description of how this sensor works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This adds an airflow sensor. These sensors are generally used to measure wind and are ultrasonic devices, measuring the airflow speed and direction using the Doppler effect.
Depends on:
Here is some use cases of such sensors from a manufacturer sensor which we have used.
https://fttechnologies.com/case-studies.
This is part of a larger plan to support an airflow sensor in PX4. @dagar
The code is heavily based on the Airspeed Sensor
##Test it
Test are added to ensure correct use.
Checklist
Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.