Skip to content

Disable ign-sensors6's (fortress) failing tests on Windows#527

Merged
iche033 merged 1 commit intoign-sensors6from
iche033/disable_win_tests
May 29, 2025
Merged

Disable ign-sensors6's (fortress) failing tests on Windows#527
iche033 merged 1 commit intoign-sensors6from
iche033/disable_win_tests

Conversation

@iche033
Copy link
Copy Markdown
Contributor

@iche033 iche033 commented May 28, 2025

🦟 Bug fix

Related issue: #503

Summary

Disables tests on Windows to reduce noise in CI

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 28, 2025
@scpeters
Copy link
Copy Markdown
Member

I assume we don't want to merge these changes forward, right?

@iche033
Copy link
Copy Markdown
Contributor Author

iche033 commented May 29, 2025

I assume we don't want to merge these changes forward, right?

That's correct. Disabled them for ign-sensors6 only

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 29, 2025
@iche033 iche033 merged commit f05f3d3 into ign-sensors6 May 29, 2025
10 of 11 checks passed
@iche033 iche033 deleted the iche033/disable_win_tests branch May 29, 2025 17:20
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants