Better GZ_PROFILE instrumentation for rendering sensors#532
Merged
iche033 merged 1 commit intogazebosim:gz-sensors9from Jul 2, 2025
Merged
Better GZ_PROFILE instrumentation for rendering sensors#532iche033 merged 1 commit intogazebosim:gz-sensors9from
iche033 merged 1 commit intogazebosim:gz-sensors9from
Conversation
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
ahcorde
approved these changes
Jul 2, 2025
iche033
approved these changes
Jul 2, 2025
Contributor
|
@Mergifyio backport gz-sensors8 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com> (cherry picked from commit 76532a6) # Conflicts: # src/LogicalCameraSensor.cc
9 tasks
iche033
pushed a commit
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com> (cherry picked from commit 76532a6) Signed-off-by: Ian Chen <ichen@openrobotics.org> # Conflicts: # src/LogicalCameraSensor.cc
iche033
pushed a commit
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com> (cherry picked from commit 76532a6) Signed-off-by: Ian Chen <ichen@openrobotics.org> # Conflicts: # src/LogicalCameraSensor.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Renderings sensors is a very powerful but also very controversial in terms of performance tool. In this patch I'd like to align profiler tooling for this type of sensors (some sensors already have desired instrumentation).
Now we can see callback execution time (copying is not free as expected) and publishing data (which is also some kind of copying).
And everything in between is a data conversion. I have some idea how to improve rtf, but it should be discussed first.
Also fixed some problems which came across (like to make CppCheck happy or similar)
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.