Skip to content

Fix: updated jacobi as template (backport #560)#564

Merged
scpeters merged 1 commit intogz-sensors8from
mergify/bp/gz-sensors8/pr-563
Nov 26, 2025
Merged

Fix: updated jacobi as template (backport #560)#564
scpeters merged 1 commit intogz-sensors8from
mergify/bp/gz-sensors8/pr-563

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 26, 2025

🦟 Bug fix

Fixes #559

Summary

Replicate warning:

  1. Go to https://build.osrfoundation.org/job/gz_sensors-ci-gz-sensors10-homebrew-amd64 before the merge
  2. Build the job
  3. See the warning appear

Changes made

-        const auto svdDecomposition =
-            beamBasis.topRows(numBeamsLocked).jacobiSvd(
-                Eigen::ComputeThinU | Eigen::ComputeThinV);

+        const Eigen::MatrixXd svdMat =
+          beamBasis.topRows(numBeamsLocked).eval();
+        using SvdT = Eigen::JacobiSVD<Eigen::MatrixXd>;
+        const SvdT svdDecomposition(svdMat,
+          Eigen::ComputeThinU | Eigen::ComputeThinV);

Checklist

Squashed the following cherry-picked commits:

(cherry picked from commit 961e2f6)
(cherry picked from commit f048f92)
(cherry picked from commit 2cda290)
(cherry picked from commit b59d445)

Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
Co-authored-by: miguelgonrod <miguelgonrod2004@gmail.com>
(cherry picked from commit 91171df)
@mergify mergify bot requested a review from iche033 as a code owner November 26, 2025 20:54
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Nov 26, 2025
@scpeters scpeters changed the title Fix: updated jacobi as template (backport #560) (backport #563) Fix: updated jacobi as template (backport #560) Nov 26, 2025
@scpeters scpeters mentioned this pull request Nov 26, 2025
9 tasks
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Nov 26, 2025
@scpeters scpeters enabled auto-merge (rebase) November 26, 2025 20:58
@scpeters scpeters merged commit dd826c0 into gz-sensors8 Nov 26, 2025
9 of 10 checks passed
@scpeters scpeters deleted the mergify/bp/gz-sensors8/pr-563 branch November 26, 2025 21:10
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants