Skip to content

Added invalid point checking to RGBD and Depth Camera plugins to set is_dense flag accordingly#575

Merged
iche033 merged 4 commits intogazebosim:gz-sensors10from
Dyst-0:gz-sensors10
Jan 7, 2026
Merged

Added invalid point checking to RGBD and Depth Camera plugins to set is_dense flag accordingly#575
iche033 merged 4 commits intogazebosim:gz-sensors10from
Dyst-0:gz-sensors10

Conversation

@Dyst-0
Copy link
Copy Markdown
Contributor

@Dyst-0 Dyst-0 commented Jan 4, 2026

🦟 Bug fix

Fixes #574

Summary

Fix similar to #180. Added gz::math::isnan and std::isinf checks to depth/coordinates in all FillMsg methods in PointUtil.cc
, which RGBD Camera and Depth Camera depend on.

Reproducibility steps described in #574.
New output should look the same, except for the is_dense flag, which should be set to false.

(maybe another test/world should be done where the point cloud only contains valid points, to check if is_dense is correctly set to true)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Dyst-0 added 3 commits January 4, 2026 09:00
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
@iche033
Copy link
Copy Markdown
Contributor

iche033 commented Jan 5, 2026

Thanks for the fix!

Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
@Dyst-0
Copy link
Copy Markdown
Contributor Author

Dyst-0 commented Jan 6, 2026

@iche033 should pass the checks now👍

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 7, 2026
@iche033 iche033 merged commit e1c5bd6 into gazebosim:gz-sensors10 Jan 7, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 7, 2026
@iche033
Copy link
Copy Markdown
Contributor

iche033 commented Jan 7, 2026

@Mergifyio backport main gz-sensors9 gz-sensors8

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 7, 2026

mergify bot pushed a commit that referenced this pull request Jan 7, 2026
…is_dense flag accordingly (#575)

Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit e1c5bd6)
mergify bot pushed a commit that referenced this pull request Jan 7, 2026
…is_dense flag accordingly (#575)

Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit e1c5bd6)
mergify bot pushed a commit that referenced this pull request Jan 7, 2026
…is_dense flag accordingly (#575)

Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit e1c5bd6)
ahcorde pushed a commit that referenced this pull request Jan 7, 2026
…is_dense flag accordingly (#575) (#580)

(cherry picked from commit e1c5bd6)

Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
ahcorde pushed a commit that referenced this pull request Jan 7, 2026
…is_dense flag accordingly (#575) (#579)

(cherry picked from commit e1c5bd6)

Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
ahcorde pushed a commit that referenced this pull request Jan 7, 2026
…is_dense flag accordingly (#575) (#578)

(cherry picked from commit e1c5bd6)

Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

RGBD and Depth camera plugins setting is_dense to True, even when point cloud has invalid points (inf)

3 participants