Open
Conversation
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
The TearDown unconditionally dereferences the engine pointer, which segfaults if the engine failed to load. Check the pointer before dereferencing. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Print the relevant github issue in the GTEST_SKIP() message. Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of gazebosim/gz-rendering#1235
Summary
While checking whether
gz-sensorstests are using ogre2 on macOS, I noticed that very few tests are usingGTEST_SKIP()for unsupported engines, so this switches thegzdbgstream thenreturnpattern to stream directly toGTEST_SKIP()as is done in gz-rendering.On Ubuntu, this shows an increase of 1 skipped test:
On macOS, there are many new skipped tests due to the removal of
ogre1.9in osrf/homebrew-simulation#3394 (see follow-up work in #605).This also fixes a segfault of
INTEGRATION_dvlwhen the render engine plugin fails to load, which also started failing on macOS whenogre1.9was removed in osrf/homebrew-simulation#3394.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.