Skip to content

Conversation

@scpeters
Copy link
Member

@scpeters scpeters commented Dec 6, 2024

🎉 New feature

Adds missing APIs

Summary

This adds SensorByName, Sensors, and SensorCount accessors to the Link class.

Test it

  1. Build this branch
  2. Run UNIT_Link_TEST
  3. Run INTEGRATION_link

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This adds SensorByName, Sensors, and SensorCount accessors
to the Link class.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from mjcarroll as a code owner December 6, 2024 19:04
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Dec 6, 2024
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be worth updating the python bindings as well or opening a ticket to remind ourselves.

@scpeters
Copy link
Member Author

scpeters commented Dec 7, 2024

LGTM. Might be worth updating the python bindings as well or opening a ticket to remind ourselves.

added python bindings in 43df8ba

@scpeters scpeters merged commit 7f002d6 into gz-sim9 Dec 8, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/link_sensor_methods_9 branch December 8, 2024 04:46
@scpeters
Copy link
Member Author

scpeters commented Dec 8, 2024

https://github.com/Mergifyio backport gz-sim8

@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2024

backport gz-sim8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 8, 2024
This adds SensorByName, Sensors, and SensorCount accessors
to the Link class with associated python bindings.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 7f002d6)
scpeters added a commit that referenced this pull request Dec 8, 2024
This adds SensorByName, Sensors, and SensorCount accessors
to the Link class with associated python bindings.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 7f002d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants